Skip to content

Commit a19f28d

Browse files
dgp1130josephperrott
authored andcommitted
refactor(github-actions): add --noEmit to lint build (#2739)
Without this, the lint job actually generates a bunch of in-tree `*.js` files. This creates a bunch of noise for developers who blindly copy-past the command to debug an issue and also risks future commands in this job running against those `*.js` files, which likely wouldn't be intended. PR Close #2739
1 parent 35131fc commit a19f28d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
- uses: ./github-actions/npm/checkout-and-setup-node
2828
- run: yarn install --immutable
2929
- name: Confirm code builds with typescript as expected
30-
run: yarn tsc -p tsconfig.json
30+
run: yarn tsc -p tsconfig.json --noEmit
3131

3232
test:
3333
timeout-minutes: 15

0 commit comments

Comments
 (0)