feat(bazel): support Karma spec bundling with rules_js

We need AMD spec bundling for Karma, until we have our own IIFE-capable
ruleset. This is a small layer on top of our much simpler spec bundling
rule.

Note that we switch to `rules_esbuild` as otherwise Esbuild can escape
sandbox due to its Go-based resolution.

Author: devversion

WORKSPACE

@@ -164,3 +164,23 @@ setup_dependencies_1()
 load("//bazel:setup_dependencies_2.bzl", "setup_dependencies_2")
 
 setup_dependencies_2()
+
+# TODO: Move this to the setup scripts. E.g. following proposals like:
+# go/ng:sharing-infra-code.
+http_archive(
+    name = "aspect_rules_esbuild",
+    sha256 = "550e33ddeb86a564b22b2c5d3f84748c6639b1b2b71fae66bf362c33392cbed8",
+    strip_prefix = "rules_esbuild-0.21.0",
+    url = "https://github.com/aspect-build/rules_esbuild/releases/download/v0.21.0/rules_esbuild-v0.21.0.tar.gz",
+)
+
+load("@aspect_rules_esbuild//esbuild:dependencies.bzl", "rules_esbuild_dependencies")
+
+rules_esbuild_dependencies()
+
+load("@aspect_rules_esbuild//esbuild:repositories.bzl", "LATEST_ESBUILD_VERSION", "esbuild_register_toolchains")
+
+esbuild_register_toolchains(
+    name = "esbuild",
+    esbuild_version = LATEST_ESBUILD_VERSION,
+)

bazel/karma/BUILD.bazel

@@ -1,6 +1,6 @@
 package(default_visibility = ["//visibility:public"])
 
-exports_files(["karma-debug-config.js"])
+exports_files(["karma-debug-config.cjs"])
 
 # Make source files available for distribution via pkg_npm
 filegroup(

bazel/karma/index.bzl

@@ -15,7 +15,7 @@ def _karma_debug_browsers_target(name, **web_test_args):
     # that is manually connected to.
     _karma_web_test(
         name = "%s_bin" % name,
-        config_file = "//bazel/karma:karma-debug-config.js",
+        config_file = "@devinfra//bazel/karma:karma-debug-config.cjs",
         tags = ["manual"],
         **web_test_args
     )
@@ -24,7 +24,7 @@ def _karma_debug_browsers_target(name, **web_test_args):
     native.sh_test(
         name = name,
         srcs = ["%s_bin" % name],
-        tags = ["manual", "local", "ibazel_notify_changes"],
+        tags = ["manual", "requires-network", "ibazel_notify_changes"],
         testonly = True,
     )
 

bazel/karma/karma-debug-config.js renamed to bazel/karma/karma-debug-config.cjs

@@ -1,5 +1,5 @@
+load("@aspect_rules_esbuild//esbuild:defs.bzl", "esbuild")
 load("@devinfra//bazel/spec-bundling:spec-entrypoint.bzl", "spec_entrypoint")
-load("@devinfra_npm//bazel:esbuild/package_json.bzl", esbuild = "bin")
 
 def spec_bundle(name, deps, bootstrap = [], testonly = True, **kwargs):
     spec_entrypoint(
@@ -9,29 +9,33 @@ def spec_bundle(name, deps, bootstrap = [], testonly = True, **kwargs):
         testonly = testonly,
     )
 
-    esbuild.esbuild(
+    esbuild(
         name = name,
         # Note: `deps` are added here to automatically collect transitive NPM
         # sources etc. and make them available for bundling.
         srcs = deps + [
             ":%s_entrypoint" % name,
         ],
         testonly = testonly,
-        outs = [
-            "%s_spec_bundle.spec.js" % name,
-            "%s_spec_bundle.spec.js.map" % name,
-        ],
-        args = [
-            "--format=iife",
-            "--bundle",
-            "--resolve-extensions=.mjs,.js",
-            "--minify",
-            "--sourcemap=external",
-            "--platform=node",
-            "--outfile=%s/%s_spec_bundle.spec.js " % (native.package_name(), name),
-            "%s/%s_entrypoint.mjs" % (native.package_name(), name),
-        ],
-        progress_message = "Creating spec-bundle",
-        silent_on_success = True,
+        bundle = True,
+        format = "iife",
+        minify = True,
+        sourcemap = "external",
+        platform = "node",
+        entry_point = ":%s_entrypoint" % name,
+        output = "%s.spec.js" % name,
+        **kwargs
+    )
+
+def spec_bundle_amd(name, workspace_name, **kwargs):
+    amd_name = "%s/%s/%s" % (workspace_name, native.package_name(), name + ".spec")
+
+    spec_bundle(
+        name,
+        config = {
+            "globalName": "__exports",
+            "banner": {"js": "define(\"%s\", [], function() {" % amd_name},
+            "footer": {"js": "return __exports;})"},
+        },
         **kwargs
     )