fixup! refactor(ng-dev/ts-circular-dependencies): reorder processing of warnings and golden existence check

Author: josephperrott

ng-dev/ts-circular-dependencies/index.ts

@@ -107,19 +107,7 @@ export function main(
     Log.warn(`   Please rerun with "--warnings" to inspect unresolved imports.`);
   }
 
-  if (goldenFile) {
-    // Golden file exists
-    if (approve) {
-      writeFileSync(goldenFile, JSON.stringify(actual, null, 2));
-      Log.info(green('✔  Updated golden file.'));
-      return 0;
-    }
-    if (!existsSync(goldenFile)) {
-      Log.error(`x  Could not find golden file: ${goldenFile}`);
-      return 1;
-    }
-  } else {
-    // No golden file exists
+  if (goldenFile === undefined) {
     if (approve) {
       Log.error(
         `x  Cannot approve circular depdencies within this repository as no golden file exists.`,
@@ -135,6 +123,17 @@ export function main(
     return 0;
   }
 
+  if (approve) {
+    writeFileSync(goldenFile, JSON.stringify(actual, null, 2));
+    Log.info(green('✔  Updated golden file.'));
+    return 0;
+  }
+
+  if (!existsSync(goldenFile)) {
+    Log.error(`x  Could not find golden file: ${goldenFile}`);
+    return 1;
+  }
+
   const expected = goldenFile ? (JSON.parse(readFileSync(goldenFile, 'utf8')) as Golden) : [];
   const {fixedCircularDeps, newCircularDeps} = compareGoldens(actual, expected);
   const isMatching = fixedCircularDeps.length === 0 && newCircularDeps.length === 0;