Skip to content

Commit d09cc27

Browse files
committed
fix(bazel): remove tooling that is no longer used: app_bundle, karma and map_size_tracking (#2927)
Remove items from the bazel tooling that are not in used anymore PR Close #2927
1 parent 361ceb6 commit d09cc27

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

69 files changed

+54
-3077
lines changed

.github/workflows/ci.yml

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -45,15 +45,16 @@ jobs:
4545
- run: yarn install --immutable
4646
- run: yarn bazel test -- //...
4747

48-
test-macos:
49-
timeout-minutes: 30
50-
runs-on: macos-latest
51-
steps:
52-
# Because the checkout and setup node action is contained in the dev-infra repo, we must
53-
# checkout the repo to be able to run the action we have created. Other repos will skip
54-
# this step.
55-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
56-
- uses: ./github-actions/npm/checkout-and-setup-node
57-
- uses: ./github-actions/bazel/setup
58-
- run: yarn install --immutable
59-
- run: yarn bazel test --sandbox_writable_path="$HOME/Library/Application Support" --test_tag_filters=macos --build_tests_only -- //...
48+
# macos testing is disabled as we do not have any targets we currently test.
49+
#test-macos:
50+
# timeout-minutes: 30
51+
# runs-on: macos-latest
52+
# steps:
53+
# # Because the checkout and setup node action is contained in the dev-infra repo, we must
54+
# # checkout the repo to be able to run the action we have created. Other repos will skip
55+
# # this step.
56+
# - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
57+
# - uses: ./github-actions/npm/checkout-and-setup-node
58+
# - uses: ./github-actions/bazel/setup
59+
# - run: yarn install --immutable
60+
# - run: yarn bazel test --sandbox_writable_path="$HOME/Library/Application Support" --test_tag_filters=macos --build_tests_only -- //...

.github/workflows/pr.yml

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -56,15 +56,16 @@ jobs:
5656
- run: yarn install --immutable
5757
- run: yarn bazel test -- //...
5858

59-
test-macos:
60-
timeout-minutes: 30
61-
runs-on: macos-latest
62-
steps:
63-
# Because the checkout and setup node action is contained in the dev-infra repo, we must
64-
# checkout the repo to be able to run the action we have created. Other repos will skip
65-
# this step.
66-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
67-
- uses: ./github-actions/npm/checkout-and-setup-node
68-
- uses: ./github-actions/bazel/setup
69-
- run: yarn install --immutable
70-
- run: yarn bazel test --sandbox_writable_path="$HOME/Library/Application Support" --test_tag_filters=macos --build_tests_only -- //...
59+
# macos testing is disabled as we do not have any targets we currently test.
60+
#test-macos:
61+
# timeout-minutes: 30
62+
# runs-on: macos-latest
63+
# steps:
64+
# # Because the checkout and setup node action is contained in the dev-infra repo, we must
65+
# # checkout the repo to be able to run the action we have created. Other repos will skip
66+
# # this step.
67+
# - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
68+
# - uses: ./github-actions/npm/checkout-and-setup-node
69+
# - uses: ./github-actions/bazel/setup
70+
# - run: yarn install --immutable
71+
# - run: yarn bazel test --sandbox_writable_path="$HOME/Library/Application Support" --test_tag_filters=macos --build_tests_only -- //...

WORKSPACE

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ workspace(
22
name = "devinfra",
33
)
44

5+
load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
56
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
67

78
# The PKG rules are needed to build tar packages for integration tests. The builtin
@@ -99,10 +100,6 @@ load("@io_bazel_rules_webtesting//web:repositories.bzl", "web_test_repositories"
99100

100101
web_test_repositories()
101102

102-
load("//bazel/browsers:browser_repositories.bzl", "browser_repositories")
103-
104-
browser_repositories()
105-
106103
load("@build_bazel_rules_nodejs//toolchains/esbuild:esbuild_repositories.bzl", "esbuild_repositories")
107104

108105
esbuild_repositories(
@@ -166,3 +163,17 @@ esbuild_register_toolchains(
166163
name = "esbuild",
167164
esbuild_version = LATEST_ESBUILD_VERSION,
168165
)
166+
167+
git_repository(
168+
name = "rules_browsers",
169+
commit = "56ef8007ea07cd1916429bca8bb523433b0e9cdc",
170+
remote = "https://github.com/devversion/rules_browsers.git",
171+
)
172+
173+
load("@rules_browsers//setup:step_1.bzl", "rules_browsers_setup_1")
174+
175+
rules_browsers_setup_1()
176+
177+
load("@rules_browsers//setup:step_2.bzl", "rules_browsers_setup_2")
178+
179+
rules_browsers_setup_2()

bazel/BUILD.bazel

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,10 @@ filegroup(
2222
"extract_types.bzl",
2323
"filter_outputs.bzl",
2424
"//bazel/api-golden:files",
25-
"//bazel/app-bundling:files",
26-
"//bazel/browsers:files",
2725
"//bazel/constraints:files",
2826
"//bazel/esbuild:files",
2927
"//bazel/git-toolchain:files",
3028
"//bazel/http-server:files",
31-
"//bazel/karma:files",
32-
"//bazel/map-size-tracking:files",
3329
"//bazel/private:files",
3430
"//bazel/remote-execution:files",
3531
"//bazel/spec-bundling:files",

bazel/app-bundling/BUILD.bazel

Lines changed: 0 additions & 21 deletions
This file was deleted.

bazel/app-bundling/brotli-compress.cjs

Lines changed: 0 additions & 21 deletions
This file was deleted.

bazel/app-bundling/esbuild.config-tmpl.mjs

Lines changed: 0 additions & 78 deletions
This file was deleted.

bazel/app-bundling/index.bzl

Lines changed: 0 additions & 130 deletions
This file was deleted.

bazel/app-bundling/terser_config.json

Lines changed: 0 additions & 12 deletions
This file was deleted.

0 commit comments

Comments
 (0)