From 682935c52ee9c58491ab532d596f1e977d5cf915 Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Fri, 27 Sep 2024 08:24:51 -0600 Subject: [PATCH] fix(ng-dev): remove formatting expectations around constant only globs Remove the formatting requirement for not including constant only globs. While they are technically less efficient, they are not worth flagging for us compared to the cost of the inefficiency. --- .github/local-actions/changelog/main.js | 2 +- ng-dev/format/formatters/buildifier.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/local-actions/changelog/main.js b/.github/local-actions/changelog/main.js index 5877610a7..08980bfe5 100644 --- a/.github/local-actions/changelog/main.js +++ b/.github/local-actions/changelog/main.js @@ -62167,7 +62167,7 @@ var Buildifier = class extends Formatter { }; } }; -var BAZEL_WARNING_FLAG = `--warnings=attr-cfg,attr-license,attr-non-empty,attr-output-default,attr-single-file,constant-glob,ctx-args,depset-iteration,depset-union,dict-concatenation,duplicated-name,filetype,git-repository,http-archive,integer-division,load,native-build,native-package,output-group,package-name,package-on-top,positional-args,redefined-variable,repository-name,string-iteration,unused-variable`; +var BAZEL_WARNING_FLAG = `--warnings=attr-cfg,attr-license,attr-non-empty,attr-output-default,attr-single-file,ctx-args,depset-iteration,depset-union,dict-concatenation,duplicated-name,filetype,git-repository,http-archive,integer-division,load,native-build,native-package,output-group,package-name,package-on-top,positional-args,redefined-variable,repository-name,string-iteration,unused-variable`; // import { join as join3 } from "path"; diff --git a/ng-dev/format/formatters/buildifier.ts b/ng-dev/format/formatters/buildifier.ts index 7d70491d2..c60c56e0d 100644 --- a/ng-dev/format/formatters/buildifier.ts +++ b/ng-dev/format/formatters/buildifier.ts @@ -49,7 +49,7 @@ export class Buildifier extends Formatter { // The warning flag for buildifier copied from angular/angular's usage. const BAZEL_WARNING_FLAG = `--warnings=attr-cfg,attr-license,attr-non-empty,attr-output-default,` + - `attr-single-file,constant-glob,ctx-args,depset-iteration,depset-union,dict-concatenation,` + + `attr-single-file,ctx-args,depset-iteration,depset-union,dict-concatenation,` + `duplicated-name,filetype,git-repository,http-archive,integer-division,load,` + `native-build,native-package,output-group,package-name,package-on-top,positional-args,` + `redefined-variable,repository-name,string-iteration,unused-variable`;