Skip to content

fix(github-actions): properly assess the full path for artifact metadata #2470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(github-actions): properly assess the full path for artifact metadata #2470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions github-actions/previews/upload-artifacts-to-firebase/extract-artifact-metadata.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19398,11 +19398,14 @@ var artifactMetadata = {
//
async function main() {
const [artifactDirPath] = process.argv.slice(2);
const fullArtifactDirPath = await fs.promises.realpath(artifactDirPath);
for (const [key, name] of Object.entries(artifactMetadata)) {
const expectedPath = path.join(artifactDirPath, name);
const expectedPath = path.normalize(path.join(fullArtifactDirPath, name));
const realPath = await fs.promises.realpath(expectedPath);
if (expectedPath !== realPath) {
throw Error(`Value for unsafe-${key} not stored directly in file as expected, instead stored in ${realPath}`);
throw Error(`Value for unsafe-${key} not stored directly in file as expected,
expected: ${expectedPath}
got: ${realPath}`);
}
const content = await fs.promises.readFile(expectedPath, "utf8");
const outputName = `unsafe-${key}`;
Expand Down
6 changes: 4 additions & 2 deletions github-actions/previews/upload-artifacts-to-firebase/lib/extract-artifact-metadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,19 @@ import {artifactMetadata} from '../../constants.js';

async function main() {
const [artifactDirPath] = process.argv.slice(2);
/** The full path to the artifact directory. */
const fullArtifactDirPath = await fs.promises.realpath(artifactDirPath);

for (const [key, name] of Object.entries(artifactMetadata)) {
/** The expected path of the artifact */
const expectedPath = path.join(artifactDirPath, name);
const expectedPath = path.normalize(path.join(fullArtifactDirPath, name));

// We confirm that the provided artifact path is actually in the expected location instead of pointing somewhere
// else to exfiltrate information.
const realPath = await fs.promises.realpath(expectedPath);
if (expectedPath !== realPath) {
throw Error(
`Value for unsafe-${key} not stored directly in file as expected, instead stored in ${realPath}`,
`Value for unsafe-${key} not stored directly in file as expected,\n expected: ${expectedPath}\n got: ${realPath}`,
);
}

Expand Down