Skip to content

fix(ng-dev): fix commitCheck functions for managed labels #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(ng-dev): fix commitCheck functions for managed labels #2544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions .github/local-actions/branch-manager/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62440,19 +62440,31 @@ var managedLabels = createTypedObject(ManagedLabel)({
DETECTED_HTTP_CHANGE: {
description: "Issues related to HTTP and HTTP Client",
name: "area: common/http",
commitCheck: (c) => c.type === "common/http" || c.type === "http",
commitCheck: (c) => c.scope === "common/http" || c.scope === "http",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_COMPILER_CHANGE: {
description: "Issues related to `ngc`, Angular's template compiler",
name: "area: compiler",
commitCheck: (c) => c.type === "compiler" || c.type === "compiler-cli",
commitCheck: (c) => c.scope === "compiler" || c.scope === "compiler-cli",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_PLATFORM_BROWSER_CHANGE: {
description: "Issues related to the framework runtime",
name: "area: core",
commitCheck: (c) => c.type === "platform-browser" || c.type === "core",
commitCheck: (c) => c.scope === "platform-browser" || c.scope === "core" || c.scope === "platform-browser-dynamic",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_PLATFORM_SERVER_CHANGE: {
description: "Issues related to server-side rendering",
name: "area: server",
commitCheck: (c) => c.scope === "platform-server",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_ZONES_CHANGE: {
description: "Issues related to zone.js",
name: "area: zones",
commitCheck: (c) => c.scope === "zone.js",
repositories: [ManagedRepositories.ANGULAR]
}
});
Expand Down
18 changes: 15 additions & 3 deletions .github/local-actions/labels-sync/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45864,19 +45864,31 @@ var managedLabels = createTypedObject(ManagedLabel)({
DETECTED_HTTP_CHANGE: {
description: "Issues related to HTTP and HTTP Client",
name: "area: common/http",
commitCheck: (c) => c.type === "common/http" || c.type === "http",
commitCheck: (c) => c.scope === "common/http" || c.scope === "http",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_COMPILER_CHANGE: {
description: "Issues related to `ngc`, Angular's template compiler",
name: "area: compiler",
commitCheck: (c) => c.type === "compiler" || c.type === "compiler-cli",
commitCheck: (c) => c.scope === "compiler" || c.scope === "compiler-cli",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_PLATFORM_BROWSER_CHANGE: {
description: "Issues related to the framework runtime",
name: "area: core",
commitCheck: (c) => c.type === "platform-browser" || c.type === "core",
commitCheck: (c) => c.scope === "platform-browser" || c.scope === "core" || c.scope === "platform-browser-dynamic",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_PLATFORM_SERVER_CHANGE: {
description: "Issues related to server-side rendering",
name: "area: server",
commitCheck: (c) => c.scope === "platform-server",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_ZONES_CHANGE: {
description: "Issues related to zone.js",
name: "area: zones",
commitCheck: (c) => c.scope === "zone.js",
repositories: [ManagedRepositories.ANGULAR]
}
});
Expand Down
18 changes: 15 additions & 3 deletions github-actions/branch-manager/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45864,19 +45864,31 @@ var managedLabels = createTypedObject(ManagedLabel)({
DETECTED_HTTP_CHANGE: {
description: "Issues related to HTTP and HTTP Client",
name: "area: common/http",
commitCheck: (c) => c.type === "common/http" || c.type === "http",
commitCheck: (c) => c.scope === "common/http" || c.scope === "http",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_COMPILER_CHANGE: {
description: "Issues related to `ngc`, Angular's template compiler",
name: "area: compiler",
commitCheck: (c) => c.type === "compiler" || c.type === "compiler-cli",
commitCheck: (c) => c.scope === "compiler" || c.scope === "compiler-cli",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_PLATFORM_BROWSER_CHANGE: {
description: "Issues related to the framework runtime",
name: "area: core",
commitCheck: (c) => c.type === "platform-browser" || c.type === "core",
commitCheck: (c) => c.scope === "platform-browser" || c.scope === "core" || c.scope === "platform-browser-dynamic",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_PLATFORM_SERVER_CHANGE: {
description: "Issues related to server-side rendering",
name: "area: server",
commitCheck: (c) => c.scope === "platform-server",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_ZONES_CHANGE: {
description: "Issues related to zone.js",
name: "area: zones",
commitCheck: (c) => c.scope === "zone.js",
repositories: [ManagedRepositories.ANGULAR]
}
});
Expand Down
18 changes: 15 additions & 3 deletions github-actions/commit-message-based-labels/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46329,19 +46329,31 @@ var managedLabels = createTypedObject(ManagedLabel)({
DETECTED_HTTP_CHANGE: {
description: "Issues related to HTTP and HTTP Client",
name: "area: common/http",
commitCheck: (c) => c.type === "common/http" || c.type === "http",
commitCheck: (c) => c.scope === "common/http" || c.scope === "http",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_COMPILER_CHANGE: {
description: "Issues related to `ngc`, Angular's template compiler",
name: "area: compiler",
commitCheck: (c) => c.type === "compiler" || c.type === "compiler-cli",
commitCheck: (c) => c.scope === "compiler" || c.scope === "compiler-cli",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_PLATFORM_BROWSER_CHANGE: {
description: "Issues related to the framework runtime",
name: "area: core",
commitCheck: (c) => c.type === "platform-browser" || c.type === "core",
commitCheck: (c) => c.scope === "platform-browser" || c.scope === "core" || c.scope === "platform-browser-dynamic",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_PLATFORM_SERVER_CHANGE: {
description: "Issues related to server-side rendering",
name: "area: server",
commitCheck: (c) => c.scope === "platform-server",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_ZONES_CHANGE: {
description: "Issues related to zone.js",
name: "area: zones",
commitCheck: (c) => c.scope === "zone.js",
repositories: [ManagedRepositories.ANGULAR]
}
});
Expand Down
18 changes: 15 additions & 3 deletions github-actions/unified-status-check/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47684,19 +47684,31 @@ var managedLabels = createTypedObject(ManagedLabel)({
DETECTED_HTTP_CHANGE: {
description: "Issues related to HTTP and HTTP Client",
name: "area: common/http",
commitCheck: (c) => c.type === "common/http" || c.type === "http",
commitCheck: (c) => c.scope === "common/http" || c.scope === "http",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_COMPILER_CHANGE: {
description: "Issues related to `ngc`, Angular's template compiler",
name: "area: compiler",
commitCheck: (c) => c.type === "compiler" || c.type === "compiler-cli",
commitCheck: (c) => c.scope === "compiler" || c.scope === "compiler-cli",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_PLATFORM_BROWSER_CHANGE: {
description: "Issues related to the framework runtime",
name: "area: core",
commitCheck: (c) => c.type === "platform-browser" || c.type === "core",
commitCheck: (c) => c.scope === "platform-browser" || c.scope === "core" || c.scope === "platform-browser-dynamic",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_PLATFORM_SERVER_CHANGE: {
description: "Issues related to server-side rendering",
name: "area: server",
commitCheck: (c) => c.scope === "platform-server",
repositories: [ManagedRepositories.ANGULAR]
},
DETECTED_ZONES_CHANGE: {
description: "Issues related to zone.js",
name: "area: zones",
commitCheck: (c) => c.scope === "zone.js",
repositories: [ManagedRepositories.ANGULAR]
}
});
Expand Down
21 changes: 18 additions & 3 deletions ng-dev/pr/common/labels/managed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,19 +47,34 @@ export const managedLabels = createTypedObject(ManagedLabel)({
DETECTED_HTTP_CHANGE: {
description: 'Issues related to HTTP and HTTP Client',
name: 'area: common/http',
commitCheck: (c: Commit) => c.type === 'common/http' || c.type === 'http',
commitCheck: (c: Commit) => c.scope === 'common/http' || c.scope === 'http',
repositories: [ManagedRepositories.ANGULAR],
},
DETECTED_COMPILER_CHANGE: {
description: "Issues related to `ngc`, Angular's template compiler",
name: 'area: compiler',
commitCheck: (c: Commit) => c.type === 'compiler' || c.type === 'compiler-cli',
commitCheck: (c: Commit) => c.scope === 'compiler' || c.scope === 'compiler-cli',
repositories: [ManagedRepositories.ANGULAR],
},
DETECTED_PLATFORM_BROWSER_CHANGE: {
description: 'Issues related to the framework runtime',
name: 'area: core',
commitCheck: (c: Commit) => c.type === 'platform-browser' || c.type === 'core',
commitCheck: (c: Commit) =>
c.scope === 'platform-browser' ||
c.scope === 'core' ||
c.scope === 'platform-browser-dynamic',
repositories: [ManagedRepositories.ANGULAR],
},
DETECTED_PLATFORM_SERVER_CHANGE: {
description: 'Issues related to server-side rendering',
name: 'area: server',
commitCheck: (c: Commit) => c.scope === 'platform-server',
repositories: [ManagedRepositories.ANGULAR],
},
DETECTED_ZONES_CHANGE: {
description: 'Issues related to zone.js',
name: 'area: zones',
commitCheck: (c: Commit) => c.scope === 'zone.js',
repositories: [ManagedRepositories.ANGULAR],
},
});
Loading