fix(ng-dev): replace bazel run @npm2//:sync with bazel sync --only=repo
#2586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
action: review
…=repo` In certain scenarios, running `bazel run @npm2//:sync` does not reliably update the aspect lock files. For example: ``` # Update the version in package.json $ yarn bazel run @npm2//:sync # Lock file is updated $ git restore .aspect $ yarn bazel run @npm2//:sync # Lock file is NOT updated ``` Switching to `bazel sync --only=repo` guarantees that the lock file is consistently updated. More context: https://angular-team.slack.com/archives/C042EU9T5/p1739398554132249
alan-agius4
force-pushed
the
bazel-sync
branch
from
9118ff2 to
c12ce56
Compare
devversion
approved these changes
Feb 13, 2025
| // alway exits with a non-zero exit code. | ||
| Log.debug(e); | ||
| Log.error(e); | ||
| Log.error(' ✘ An error occurred while updating Aspect lock files.'); |
Member
There was a problem hiding this comment.
are we sure it exits gracefully?
Contributor
Author
There was a problem hiding this comment.
Yes, I tried a couple of times and it always exited with a zero error code.
alan-agius4
added
action: merge
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Feb 13, 2025
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this pull request
Feb 13, 2025
alan-agius4
added a commit
to angular/angular-cli
that referenced
this pull request
Feb 13, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain scenarios, running
bazel run @npm2//:syncdoes not reliably update the aspect lock files. For example:Switching to
bazel sync --only=repoguarantees that the lock file is consistently updated.More context: https://angular-team.slack.com/archives/C042EU9T5/p1739398554132249