Skip to content

feat(bazel): still support cross-compiling for Windows #2622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025
Merged

feat(bazel): still support cross-compiling for Windows #2622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions bazel/git-toolchain/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,18 @@ toolchain(
toolchain = ":git_macos_arm64",
toolchain_type = ":toolchain_type",
)

toolchain(
name = "git_windows_toolchain",
# TODO(devversion): Consult with Bazel team on best practices.
# Toolchain selection isn't able to cross-compile if we require Windows
# also as execution platform. This shouldn't be necessary because the toolchain
# is only used for target platform execution (not to be confused with Bazel execution).
# exec_compatible_with = [],
target_compatible_with = [
"@platforms//os:windows",
"@platforms//cpu:x86_64",
],
toolchain = ":git_windows",
toolchain_type = ":toolchain_type",
)
1 change: 0 additions & 1 deletion bazel/remote-execution/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ platform(
constraint_values = [
"@platforms//os:linux",
"@platforms//cpu:x86_64",
"@bazel_tools//tools/cpp:clang",
],
exec_properties = {
# We use the official Puppeteer docker image that supports launching browsers. Note that we
Expand Down
Loading