Skip to content

fix(ng-dev): add additional context for why retries occur during github API requests in merge process #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(ng-dev): add additional context for why retries occur during github API requests in merge process #2753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ng-dev/release/publish/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,10 @@ export abstract class ReleaseAction {
* release commit and is the direct child of the previous sha provided.
*
* The method will make one recursive attempt to check again before throwing an error if
* any error occurs during this validation.
* any error occurs during this validation. This exists as an attempt to handle transient
* timeouts from Github along with cases, where the Github API response does not keep up
* with the timing from when we perform a merge to when we verify that the merged commit is
* present in the upstream branch.
*/
private async _getAndValidateLatestCommitForPublishing(
branch: string,
Expand Down