fix(github-actions): delete obsolete branches and close superseded PRs #2773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the `create-pr-for-changes` workflow, old branches are not being deleted, and the content of superseded PRs remains open. This change ensures that: - Obsolete branches are deleted after PR creation. - Previously created PRs with outdated content are automatically closed. Example: angular/angular#61203
alan-agius4
added
action: merge
alan-agius4
commented
May 9, 2025
| } | ||
|
|
||
| // Gather PRs (if any) that will be superseded by the PR that will be created. | ||
| const { |
Contributor
Author
There was a problem hiding this comment.
Note: We could simplify this logic, if we keep re-using the same branch (like renovate)
devversion
approved these changes
May 9, 2025
| const { | ||
| data: {items: supersededPrs}, | ||
| } = await git.github.search.issuesAndPullRequests({ | ||
| advanced_search: 'true', |
Member
There was a problem hiding this comment.
Yeah, when I read the commit description, I remembered that we already had logic for this in place. Is this just a fix because it didn't work?
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
create-pr-for-changesworkflow, old branches are not being deleted, and the content of superseded PRs remains open. This change ensures that:Example: angular/angular#61203