Skip to content

refactor: remove docker sys_admin capability #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+1 −4
Closed

refactor: remove docker sys_admin capability #2808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bazel/browsers/chromium/chromium.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"browserName": "chrome",
"goog:chromeOptions": {
"binary": "%FILE:CHROMIUM%",
"args": ["--headless", "--use-gl=swiftshader-webgl"]
"args": ["--headless", "--use-gl=swiftshader-webgl", "--no-sandbox"]
},
"google:wslConfig": {
"binary": "%FILE:CHROMEDRIVER%",
Expand Down
3 changes: 0 additions & 3 deletions bazel/remote-execution/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ platform(
# it needs to be updated. e.g. for a more recent Bash version, or new system settings that are
# required for launching browsers.
"container-image": "docker://us-west2-docker.pkg.dev/internal-200822/remote-execution-images/angular-devinfra-rbe-image@sha256:3389d808edbcdf8999338fd617dda68cdbaa259b431f19e41e58941cdac900a3",
# The `SYS_ADMIN` capability is added so that browsers can be launched with sandbox mode enabled. Related
# # information: https://developers.google.com/web/tools/puppeteer/troubleshooting#running_puppeteer_in_docker
"dockerAddCapabilities": "SYS_ADMIN",
# By default in Google Cloud Remote build execution, network access is disabled. We explicitly set the
# property in the platform again in case the default ever changes. Network access is not desirable in
# Bazel builds as it is potential source of flaky tests and therefore also breaks hermeticity.
Expand Down