Skip to content

Conversation

@josephperrott
Copy link
Member

No description provided.

…he merge ready check

The merge ready check is a more logical place for this check to occur
…ked as merge ready

The merge ready label should be applied when we know something is ready for merge, it does not make sense that the
check only occurs once the label is applied as it should provide information about if it is merge ready.
@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Jul 17, 2025
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Jul 17, 2025

This would mean that you could still put action: merge on something and that label would sit there while it's not actually merge ready. The point of the original check was to make sure it does not show up when you run the caretaker check or look at all the items in the merge queue, which even though we'd like to assume people use a saved search, typically is just people viewing all the action: merge PRs. So this wouldn't solve that problem. We should only be putting action: merge on PRs that are essentially already ready to merge or at least have final tests runs in progress.

@josephperrott
Copy link
Member Author

I think you are thinking of a different action, this is not the action that applies/removes labels. This is setting the mergeability status.

The appying/removing labels based on draft status is unaffected by this.

@thePunderWoman
Copy link
Contributor

Ahhhhhh, yes you are correct. Disregard my comment.

@josephperrott
Copy link
Member Author

This PR was merged into the repository by commit 872ab8f.

The changes were merged into the following branches: main

josephperrott added a commit that referenced this pull request Jul 17, 2025
…ked as merge ready (#2899)

The merge ready label should be applied when we know something is ready for merge, it does not make sense that the
check only occurs once the label is applied as it should provide information about if it is merge ready.

PR Close #2899
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants