Skip to content

fix(bazel/spec-bundling): allow for non init suffixed files to be used as bootstrap files #2908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(bazel/spec-bundling): allow for non init suffixed files to be used as bootstrap files #2908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion bazel/spec-bundling/spec-entrypoint.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,10 @@ def _spec_entrypoint_impl(ctx):
# Note: `to_list()` is an expensive operation but we need to do this for every
# dependency here in order to be able to filter out spec files from depsets.
direct_bootstrap_files = depset(transitive = bootstrap_direct_deps).to_list()
bootstrap_files = _filter_files(direct_bootstrap_files, ["init"])

# Filter to only js and mjs files, we can't always define what the name of the files
# needed for bootstrapping are so we rely on the user to provide the exact list.
bootstrap_files = _filter_files(direct_bootstrap_files, [""])

ctx.actions.write(
output = output,
Expand Down
Loading