Skip to content

fix(bazel): use cjs for api golden scripting #2915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(bazel): use cjs for api golden scripting #2915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bazel/api-golden/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ package(default_visibility = ["//visibility:public"])

exports_files([
"index.ts",
"index_npm_packages.ts",
"index_npm_packages.cts",
])

ts_project(
name = "api-golden",
srcs = [
"find_entry_points.ts",
"index_npm_packages.ts",
"index_npm_packages.cts",
"interop_module_mappings.ts",
"path-normalize.ts",
"test_api_report.ts",
Expand Down
2 changes: 1 addition & 1 deletion bazel/api-golden/find_entry_points.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import {dirname, join, relative} from 'path';
import {lstatSync, readFileSync, readdirSync} from 'fs';

import {PackageJson} from './index_npm_packages.js';
import {PackageJson} from './index_npm_packages.cjs';

/** Interface describing a resolved NPM package entry point. */
export interface PackageEntryPoint {
Expand Down
0 bazel/api-golden/index_npm_packages.ts → bazel/api-golden/index_npm_packages.cts
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions bazel/api-golden/index_rjs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def api_golden_test_npm_package(
js_test(
name = name,
data = data,
entry_point = "@devinfra//bazel/api-golden:index_npm_packages.js",
entry_point = "@devinfra//bazel/api-golden:index_npm_packages.cjs",
args = [golden_dir, npm_package, "false", quoted_export_pattern] + type_names,
env = {"RJS_MODE": "true" if not interop_mode else "false"},
**kwargs
Expand All @@ -52,7 +52,7 @@ def api_golden_test_npm_package(
name = name + ".accept",
testonly = True,
data = data,
entry_point = "@devinfra//bazel/api-golden:index_npm_packages.js",
entry_point = "@devinfra//bazel/api-golden:index_npm_packages.cjs",
args = [golden_dir, npm_package, "true", quoted_export_pattern] + type_names,
# TODO: Determine why this is needed but only for this `.accept` action
# https://github.com/angular/dev-infra/issues/2742
Expand Down
Loading