build: disallow fixup commit in this repo #3015
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See associated pull request for more information. Closes angular#2995 as a pr takeover
This is so that `fixup!` commit do not end up accidently in the main branch. Example: angular@b9c76c9
angular-robot
bot
added
the
area: build & ci
josephperrott
requested changes
Aug 28, 2025
Member
josephperrott
left a comment
josephperrott
left a comment
There was a problem hiding this comment.
I personally strongly prefer fixup commits. Fixup commits are properly handled by the ng-dev tooling used for merging PRs in this repo.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that
fixup!commit do not end up accidently in the main branch. Example: b9c76c9