test: remove appveyor workarounds

Author: filipesilva

packages/angular_devkit/build_angular/test/browser/rebuild_spec_large.ts

@@ -12,13 +12,6 @@ import { TestLogger, Timeout, browserTargetSpec, host, runTargetSpec } from '../
 import { lazyModuleFiles, lazyModuleImport } from './lazy-module_spec_large';
 
 
-// TODO: replace this with an "it()" macro that's reusable globally.
-let linuxOnlyIt: typeof it = it;
-if (process.platform.startsWith('win')) {
-  linuxOnlyIt = xit;
-}
-
-
 describe('Browser Builder rebuilds', () => {
   const outputPath = normalize('dist');
 
@@ -27,12 +20,6 @@ describe('Browser Builder rebuilds', () => {
 
 
   it('rebuilds on TS file changes', (done) => {
-    if (process.env['APPVEYOR']) {
-      // TODO: This test fails on Windows CI, figure out why.
-      done();
-
-      return;
-    }
     const goldenValueFiles: { [path: string]: string } = {
       'src/app/app.module.ts': `
         import { BrowserModule } from '@angular/platform-browser';
@@ -208,7 +195,7 @@ describe('Browser Builder rebuilds', () => {
   }, Timeout.Basic);
 
 
-  linuxOnlyIt('rebuilds after errors in AOT', (done) => {
+  it('rebuilds after errors in AOT', (done) => {
     // Save the original contents of `./src/app/app.component.ts`.
     const origContent = virtualFs.fileBufferToString(
       host.scopedSync().read(normalize('src/app/app.component.ts')));
@@ -270,7 +257,7 @@ describe('Browser Builder rebuilds', () => {
   }, Timeout.Complex);
 
 
-  linuxOnlyIt('rebuilds AOT factories', (done) => {
+  it('rebuilds AOT factories', (done) => {
 
     host.writeMultipleFiles({
       'src/app/app.component.css': `

packages/angular_devkit/build_angular/test/protractor/works_spec_large.ts

@@ -11,32 +11,25 @@ import { retry } from 'rxjs/operators';
 import { host, protractorTargetSpec, runTargetSpec } from '../utils';
 
 
-// TODO: replace this with an "it()" macro that's reusable globally.
-let linuxOnlyIt: typeof it = it;
-if (process.platform.startsWith('win')) {
-  linuxOnlyIt = xit;
-}
-
-
 describe('Protractor Builder', () => {
   beforeEach(done => host.initialize().toPromise().then(done, done.fail));
   afterEach(done => host.restore().toPromise().then(done, done.fail));
 
-  linuxOnlyIt('works', (done) => {
+  it('works', (done) => {
     runTargetSpec(host, protractorTargetSpec).pipe(
       retry(3),
     ).toPromise().then(done, done.fail);
   }, 30000);
 
-  linuxOnlyIt('works with no devServerTarget', (done) => {
+  it('works with no devServerTarget', (done) => {
     const overrides = { devServerTarget: undefined };
 
     runTargetSpec(host, protractorTargetSpec, overrides).pipe(
       // This should fail because no server is available for connection.
     ).subscribe(undefined, () => done(), done.fail);
   }, 30000);
 
-  linuxOnlyIt('overrides protractor specs', (done) => {
+  it('overrides protractor specs', (done) => {
     host.scopedSync().rename(normalize('./e2e/app.e2e-spec.ts'),
       normalize('./e2e/renamed-app.e2e-spec.ts'));
 
@@ -47,7 +40,7 @@ describe('Protractor Builder', () => {
     ).toPromise().then(done, done.fail);
   }, 60000);
 
-  linuxOnlyIt('overrides protractor suites', (done) => {
+  it('overrides protractor suites', (done) => {
     host.scopedSync().rename(normalize('./e2e/app.e2e-spec.ts'),
       normalize('./e2e/renamed-app.e2e-spec.ts'));
 

packages/angular_devkit/build_ng_packagr/src/build/index_spec_large.ts

@@ -12,13 +12,6 @@ import { NodeJsSyncHost } from '@angular-devkit/core/node';
 import { concatMap, tap } from 'rxjs/operators';
 
 
-// TODO: replace this with an "it()" macro that's reusable globally.
-let linuxOnlyIt: typeof it = it;
-if (process.platform.startsWith('win')) {
-  linuxOnlyIt = xit;
-}
-
-
 describe('NgPackagr Builder', () => {
   const workspaceFile = normalize('angular.json');
   const devkitRoot = normalize((global as any)._DevKitRoot); // tslint:disable-line:no-any
@@ -30,7 +23,7 @@ describe('NgPackagr Builder', () => {
   const host = new NodeJsSyncHost();
   const workspace = new experimental.workspace.Workspace(workspaceRoot, host);
 
-  linuxOnlyIt('works', (done) => {
+  it('works', (done) => {
     const targetSpec: TargetSpecifier = { project: 'lib', target: 'build' };
 
     return workspace.loadWorkspaceFromHost(workspaceFile).pipe(
@@ -40,7 +33,7 @@ describe('NgPackagr Builder', () => {
     ).toPromise().then(done, done.fail);
   }, 30000);
 
-  linuxOnlyIt('tests works', (done) => {
+  it('tests works', (done) => {
     const targetSpec: TargetSpecifier = { project: 'lib', target: 'test' };
 
     return workspace.loadWorkspaceFromHost(workspaceFile).pipe(