fix: parseId only converts id to number if the collection ids are numeric. (#138)

In early v0.4.x refactor, accidentally removed test for numeric collection ids
which lead to issue #136.

This PR fixes that problem, tests it, and strengthens error handling.

Breaking change: `genIdDefault` will only generate ids for collections with numeric id;
throws error otherwise.

Updated `rollup.config.js` so it doesn’t fail. Still weirdly runs an unspecified `cjs` rollup config that I can’t find (which produces numerous warnings) before doing the right thing and running the `mud` config.

Also does not work if follow instructions and use the `output` property of `rollup.config.js`; does work when I do it “wrong” and put the options in the root.

closes #136

Author: wardbell

CHANGELOG.md

@@ -8,6 +8,13 @@ because this is a development tool, not a production product.
 We do try to tell you about such changes in this `CHANGELOG.md`
 and we fix bugs as fast as we can.
 
+<a id="0.4.4"></a>
+## 0.4.4 (2017-09-11)
+closes #136
+
+A **breaking change** if you expected `genId` to generate ids for a collection
+with non-numeric `item.id`.
+
 <a id="0.4.3"></a>
 ## 0.4.3 (2017-09-11)
 Refactoring for clarity and to correctly reflect intent.

README.md

@@ -427,4 +427,16 @@ these tests reference the library source files.
 
 The `karma-test-shim.js` add `in-mem` to the list of app folders that SystemJS should resolve.
 
+## Rollup
+
+The gulp "umd" task runs rollup for tree-shaking.
+
+I don't remember it ever working without a lot of warnings.
+In v.0.4.x, updated to v.0.49 ... which required updating of the `rollup.config.js`.
+
+Still weirdly runs an unspecified `cjs` rollup config first that I can’t find (which produces numerous warnings) before doing the right thing and running the `umd` config. 
+
+Also does not work if follow instructions and use the `output` property of `rollup.config.js`; does work when config it “wrong” and put the options in the root.
+
+Ignoring these issues for now.
 

backend.service.d.ts

@@ -14,6 +14,7 @@ export declare abstract class BackendService {
     protected db: Object;
     protected dbReadySubject: BehaviorSubject<boolean>;
     private passThruBackend;
+    protected requestInfoUtils: RequestInfoUtilities;
     constructor(inMemDbService: InMemoryDbService, config?: InMemoryBackendConfigArgs);
     protected readonly dbReady: Observable<boolean>;
     /**
@@ -117,21 +118,22 @@ export declare abstract class BackendService {
     }>(collection: T[], id: any): T;
     /**
      * Generate the next available id for item in this collection
-     * @param collection - collection of items with `id` key property
      * Use method from `inMemDbService` if it exists and returns a value,
-     * else delegates to genIdDefault
+     * else delegates to `genIdDefault`.
+     * @param collection - collection of items with `id` key property
      */
     protected genId<T extends {
         id: any;
-    }>(collection: T[]): any;
+    }>(collection: T[], collectionName: string): any;
     /**
      * Default generator of the next available id for item in this collection
+     * This default implementation works only for numeric ids.
      * @param collection - collection of items with `id` key property
-     * This default implementation assumes integer ids; returns `1` otherwise
+     * @param collectionName - name of the collection
      */
     protected genIdDefault<T extends {
         id: any;
-    }>(collection: T[]): any;
+    }>(collection: T[], collectionName: string): any;
     protected get({collection, collectionName, headers, id, query, url}: RequestInfo): ResponseOptions;
     /** Get JSON body from the request object */
     protected abstract getJsonBody(req: any): any;
@@ -144,6 +146,11 @@ export declare abstract class BackendService {
      * through to the "real" backend.
      */
     protected getPassThruBackend(): PassThruBackend;
+    /**
+     * Get utility methods from this service instance.
+     * Useful within an HTTP method override
+     */
+    protected getRequestInfoUtils(): RequestInfoUtilities;
     /**
      * return canonical HTTP method name (lowercase) from the request object
      * e.g. (req.method || 'get').toLowerCase();
@@ -153,7 +160,14 @@ export declare abstract class BackendService {
     protected abstract getRequestMethod(req: any): string;
     protected indexOf(collection: any[], id: number): number;
     /** Parse the id as a number. Return original value if not a number. */
-    protected parseId(id: string): any;
+    protected parseId(collection: any[], collectionName: string, id: string): any;
+    /**
+     * return true if can determine that the collection's `item.id` is a number
+     * This implementation can't tell if the collection is empty so it assumes NO
+     * */
+    protected isCollectionIdNumeric<T extends {
+        id: any;
+    }>(collection: T[], collectionName: string): boolean;
     /**
      * Parses the request URL into a `ParsedRequestUrl` object.
      * Parsing depends upon certain values of `config`: `apiBase`, `host`, and `urlRoot`.
@@ -175,7 +189,6 @@ export declare abstract class BackendService {
     protected post({collection, collectionName, headers, id, req, resourceUrl, url}: RequestInfo): ResponseOptions;
     protected put({collection, collectionName, headers, id, req, url}: RequestInfo): ResponseOptions;
     protected removeById(collection: any[], id: number): boolean;
-    protected readonly requestInfoUtils: RequestInfoUtilities;
     /**
      * Tell your in-mem "database" to reset.
      * returns Observable of the database because resetting it could be async

backend.service.js

@@ -1 +1 @@
-[{"__symbolic":"module","version":3,"metadata":{"BackendService":{"__symbolic":"class","members":{"__ctor__":[{"__symbolic":"constructor","parameters":[{"__symbolic":"reference","module":"./interfaces","name":"InMemoryDbService"},{"__symbolic":"reference","module":"./interfaces","name":"InMemoryBackendConfigArgs"}]}],"handleRequest":[{"__symbolic":"method"}],"handleRequest_":[{"__symbolic":"method"}],"addDelay":[{"__symbolic":"method"}],"applyQuery":[{"__symbolic":"method"}],"bind":[{"__symbolic":"method"}],"bodify":[{"__symbolic":"method"}],"clone":[{"__symbolic":"method"}],"collectionHandler":[{"__symbolic":"method"}],"commands":[{"__symbolic":"method"}],"createErrorResponseOptions":[{"__symbolic":"method"}],"createHeaders":[{"__symbolic":"method"}],"createPassThruBackend":[{"__symbolic":"method"}],"createQueryMap":[{"__symbolic":"method"}],"createResponse$":[{"__symbolic":"method"}],"createResponse$fromResponseOptions$":[{"__symbolic":"method"}],"createResponseOptions$":[{"__symbolic":"method"}],"delete":[{"__symbolic":"method"}],"findById":[{"__symbolic":"method"}],"genId":[{"__symbolic":"method"}],"genIdDefault":[{"__symbolic":"method"}],"get":[{"__symbolic":"method"}],"getJsonBody":[{"__symbolic":"method"}],"getLocation":[{"__symbolic":"method"}],"getPassThruBackend":[{"__symbolic":"method"}],"getRequestMethod":[{"__symbolic":"method"}],"indexOf":[{"__symbolic":"method"}],"parseId":[{"__symbolic":"method"}],"parseRequestUrl":[{"__symbolic":"method"}],"post":[{"__symbolic":"method"}],"put":[{"__symbolic":"method"}],"removeById":[{"__symbolic":"method"}],"resetDb":[{"__symbolic":"method"}]}}}},{"__symbolic":"module","version":1,"metadata":{"BackendService":{"__symbolic":"class","members":{"__ctor__":[{"__symbolic":"constructor","parameters":[{"__symbolic":"reference","module":"./interfaces","name":"InMemoryDbService"},{"__symbolic":"reference","module":"./interfaces","name":"InMemoryBackendConfigArgs"}]}],"handleRequest":[{"__symbolic":"method"}],"handleRequest_":[{"__symbolic":"method"}],"addDelay":[{"__symbolic":"method"}],"applyQuery":[{"__symbolic":"method"}],"bind":[{"__symbolic":"method"}],"bodify":[{"__symbolic":"method"}],"clone":[{"__symbolic":"method"}],"collectionHandler":[{"__symbolic":"method"}],"commands":[{"__symbolic":"method"}],"createErrorResponseOptions":[{"__symbolic":"method"}],"createHeaders":[{"__symbolic":"method"}],"createPassThruBackend":[{"__symbolic":"method"}],"createQueryMap":[{"__symbolic":"method"}],"createResponse$":[{"__symbolic":"method"}],"createResponse$fromResponseOptions$":[{"__symbolic":"method"}],"createResponseOptions$":[{"__symbolic":"method"}],"delete":[{"__symbolic":"method"}],"findById":[{"__symbolic":"method"}],"genId":[{"__symbolic":"method"}],"genIdDefault":[{"__symbolic":"method"}],"get":[{"__symbolic":"method"}],"getJsonBody":[{"__symbolic":"method"}],"getLocation":[{"__symbolic":"method"}],"getPassThruBackend":[{"__symbolic":"method"}],"getRequestMethod":[{"__symbolic":"method"}],"indexOf":[{"__symbolic":"method"}],"parseId":[{"__symbolic":"method"}],"parseRequestUrl":[{"__symbolic":"method"}],"post":[{"__symbolic":"method"}],"put":[{"__symbolic":"method"}],"removeById":[{"__symbolic":"method"}],"resetDb":[{"__symbolic":"method"}]}}}}]
+[{"__symbolic":"module","version":3,"metadata":{"BackendService":{"__symbolic":"class","members":{"__ctor__":[{"__symbolic":"constructor","parameters":[{"__symbolic":"reference","module":"./interfaces","name":"InMemoryDbService"},{"__symbolic":"reference","module":"./interfaces","name":"InMemoryBackendConfigArgs"}]}],"handleRequest":[{"__symbolic":"method"}],"handleRequest_":[{"__symbolic":"method"}],"addDelay":[{"__symbolic":"method"}],"applyQuery":[{"__symbolic":"method"}],"bind":[{"__symbolic":"method"}],"bodify":[{"__symbolic":"method"}],"clone":[{"__symbolic":"method"}],"collectionHandler":[{"__symbolic":"method"}],"commands":[{"__symbolic":"method"}],"createErrorResponseOptions":[{"__symbolic":"method"}],"createHeaders":[{"__symbolic":"method"}],"createPassThruBackend":[{"__symbolic":"method"}],"createQueryMap":[{"__symbolic":"method"}],"createResponse$":[{"__symbolic":"method"}],"createResponse$fromResponseOptions$":[{"__symbolic":"method"}],"createResponseOptions$":[{"__symbolic":"method"}],"delete":[{"__symbolic":"method"}],"findById":[{"__symbolic":"method"}],"genId":[{"__symbolic":"method"}],"genIdDefault":[{"__symbolic":"method"}],"get":[{"__symbolic":"method"}],"getJsonBody":[{"__symbolic":"method"}],"getLocation":[{"__symbolic":"method"}],"getPassThruBackend":[{"__symbolic":"method"}],"getRequestInfoUtils":[{"__symbolic":"method"}],"getRequestMethod":[{"__symbolic":"method"}],"indexOf":[{"__symbolic":"method"}],"parseId":[{"__symbolic":"method"}],"isCollectionIdNumeric":[{"__symbolic":"method"}],"parseRequestUrl":[{"__symbolic":"method"}],"post":[{"__symbolic":"method"}],"put":[{"__symbolic":"method"}],"removeById":[{"__symbolic":"method"}],"resetDb":[{"__symbolic":"method"}]}}}},{"__symbolic":"module","version":1,"metadata":{"BackendService":{"__symbolic":"class","members":{"__ctor__":[{"__symbolic":"constructor","parameters":[{"__symbolic":"reference","module":"./interfaces","name":"InMemoryDbService"},{"__symbolic":"reference","module":"./interfaces","name":"InMemoryBackendConfigArgs"}]}],"handleRequest":[{"__symbolic":"method"}],"handleRequest_":[{"__symbolic":"method"}],"addDelay":[{"__symbolic":"method"}],"applyQuery":[{"__symbolic":"method"}],"bind":[{"__symbolic":"method"}],"bodify":[{"__symbolic":"method"}],"clone":[{"__symbolic":"method"}],"collectionHandler":[{"__symbolic":"method"}],"commands":[{"__symbolic":"method"}],"createErrorResponseOptions":[{"__symbolic":"method"}],"createHeaders":[{"__symbolic":"method"}],"createPassThruBackend":[{"__symbolic":"method"}],"createQueryMap":[{"__symbolic":"method"}],"createResponse$":[{"__symbolic":"method"}],"createResponse$fromResponseOptions$":[{"__symbolic":"method"}],"createResponseOptions$":[{"__symbolic":"method"}],"delete":[{"__symbolic":"method"}],"findById":[{"__symbolic":"method"}],"genId":[{"__symbolic":"method"}],"genIdDefault":[{"__symbolic":"method"}],"get":[{"__symbolic":"method"}],"getJsonBody":[{"__symbolic":"method"}],"getLocation":[{"__symbolic":"method"}],"getPassThruBackend":[{"__symbolic":"method"}],"getRequestInfoUtils":[{"__symbolic":"method"}],"getRequestMethod":[{"__symbolic":"method"}],"indexOf":[{"__symbolic":"method"}],"parseId":[{"__symbolic":"method"}],"isCollectionIdNumeric":[{"__symbolic":"method"}],"parseRequestUrl":[{"__symbolic":"method"}],"post":[{"__symbolic":"method"}],"put":[{"__symbolic":"method"}],"removeById":[{"__symbolic":"method"}],"resetDb":[{"__symbolic":"method"}]}}}}]