fix: clone request data (#165)

closes #164

Author: wardbell

CHANGELOG.md

@@ -8,6 +8,10 @@ because this is a development tool, not a production product.
 We do try to tell you about such changes in this `CHANGELOG.md`
 and we fix bugs as fast as we can.
 
+<a id="0.5.2"></a>
+## 0.5.2 (2017-12-10)
+No longer modify the request data coming from client. Fixes #164 
+
 <a id="0.5.1"></a>
 ## 0.5.1 (2017-10-21)
 Support Angular v5.

backend.service.js

@@ -1,6 +1,6 @@
 {
   "name": "angular-in-memory-web-api",
-  "version": "0.5.1",
+  "version": "0.5.2",
   "description": "An in-memory web api for Angular demos and tests",
   "main": "bundles/in-memory-web-api.umd.js",
   "module": "index.js",

backend.service.js.map

@@ -201,8 +201,7 @@ export abstract class BackendService {
   }
 
   protected bodify(data: any) {
-    const body = this.clone(data);
-    return this.config.dataEncapsulation ? { data: body } : body;
+    return this.config.dataEncapsulation ? { data } : data;
   }
 
   protected clone(data: any) {
@@ -433,7 +432,7 @@ export abstract class BackendService {
       return this.createErrorResponseOptions(url, STATUS.NOT_FOUND, `'${collectionName}' with id='${id}' not found`);
     }
     return {
-      body: this.bodify(data),
+      body: this.bodify(this.clone(data)),
       headers: headers,
       status: STATUS.OK
     };
@@ -585,7 +584,7 @@ export abstract class BackendService {
   // Create entity
   // Can update an existing entity too if post409 is false.
   protected post({ collection, collectionName, headers, id, req, resourceUrl, url }: RequestInfo): ResponseOptions {
-    const item = this.getJsonBody(req);
+    const item = this.clone(this.getJsonBody(req));
 
     // tslint:disable-next-line:triple-equals
     if (item.id == undefined) {
@@ -629,7 +628,7 @@ export abstract class BackendService {
   // Update existing entity
   // Can create an entity too if put404 is false.
   protected put({ collection, collectionName, headers, id, req, url }: RequestInfo): ResponseOptions {
-    const item = this.getJsonBody(req);
+    const item = this.clone(this.getJsonBody(req));
     // tslint:disable-next-line:triple-equals
     if (item.id == undefined) {
       return this.createErrorResponseOptions(url, STATUS.NOT_FOUND, `Missing '${collectionName}' id`);

bundles/in-memory-web-api.umd.js

@@ -169,6 +169,20 @@ describe('Http Backend Service', () => {
       );
     }));
 
+    it('can generate the id when add a hero with no id', async(() => {
+      const hero = new Hero(null, 'SuperDooper');
+      http.post('api/heroes', hero)
+        .map(res => res.json())
+        .subscribe(
+          replyHero => {
+            expect(replyHero.id).toBeTruthy('added hero should have an id');
+            expect(replyHero).not.toBe(hero,
+              'reply hero should not be the request hero');
+          },
+          failure
+        );
+    }));
+
     it('can get nobodies (empty collection)', async(() => {
       http.get('api/nobodies')
       .map(res => res.json())

package.json

@@ -213,6 +213,19 @@ describe('HttpClient Backend Service', () => {
       );
     }));
 
+    it('can generate the id when add a hero with no id', async(() => {
+      const hero = new Hero(null, 'SuperDooper');
+      http.post<Hero>('api/heroes', hero)
+        .subscribe(
+          replyHero => {
+            expect(replyHero.id).toBeTruthy('added hero should have an id');
+            expect(replyHero).not.toBe(hero,
+              'reply hero should not be the request hero');
+          },
+          failure
+        );
+    }));
+
     it('can get nobodies (empty collection)', async(() => {
       http.get<Hero[]>('api/nobodies')
       .subscribe(