Skip to content
This repository was archived by the owner on Dec 18, 2024. It is now read-only.

Commit fc36e90

Browse files
committed
ci: enable ASPECT_RULES_JS_FROZEN_PNPM_LOCK to ensure outdated pnpm file is flagged
In the migration period, until we decide to switch to `pnpm` fully, a pnpm lock file needs to be kept in sync. By default, `rules_js` will try to sync it automatically, but rather we would want to flag it as an error on CI if the pnpm file is outdated- so that not all users need to pay the cost of having to run `pnpm import` from time to time.
1 parent c96ab0f commit fc36e90

File tree

1 file changed

+76
-68
lines changed

1 file changed

+76
-68
lines changed

.circleci/config.yml

Lines changed: 76 additions & 68 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@ var_4: &save_cache
2828
save_cache:
2929
key: *cache_key
3030
paths:
31-
- "node_modules"
31+
- 'node_modules'
3232

3333
var_5: &yarn_install
3434
run:
35-
name: "Installing project dependencies"
35+
name: 'Installing project dependencies'
3636
command: yarn install --frozen-lockfile --non-interactive
3737

3838
# https://circleci.com/docs/2.0/workflows/#using-workspaces-to-share-data-among-jobs
@@ -58,12 +58,12 @@ jobs:
5858
lint:
5959
<<: *job_defaults
6060
steps:
61-
- checkout
62-
- restore_cache:
63-
key: *cache_key
64-
- *yarn_install
65-
- run: yarn lint
66-
- *save_cache
61+
- checkout
62+
- restore_cache:
63+
key: *cache_key
64+
- *yarn_install
65+
- run: yarn lint
66+
- *save_cache
6767

6868
build:
6969
<<: *job_defaults
@@ -72,24 +72,24 @@ jobs:
7272
# https://circleci.com/docs/2.0/configuration-reference/#resource_class
7373
resource_class: large
7474
steps:
75-
- checkout
76-
- restore_cache:
77-
key: *cache_key
78-
- *yarn_install
79-
- run: yarn prod-build
80-
- *save_cache
81-
- store_build_output
75+
- checkout
76+
- restore_cache:
77+
key: *cache_key
78+
- *yarn_install
79+
- run: yarn prod-build
80+
- *save_cache
81+
- store_build_output
8282

8383
test:
8484
<<: *job_defaults
8585
steps:
86-
- checkout
87-
- browser-tools/install-chrome
88-
- restore_cache:
89-
key: *cache_key
90-
- *yarn_install
91-
- browser-tools/install-browser-tools
92-
- run: yarn test --watch false --progress=false
86+
- checkout
87+
- browser-tools/install-chrome
88+
- restore_cache:
89+
key: *cache_key
90+
- *yarn_install
91+
- browser-tools/install-browser-tools
92+
- run: yarn test --watch false --progress=false
9393

9494
lighthouse_audits:
9595
<<: *job_defaults
@@ -106,69 +106,77 @@ jobs:
106106
<<: *job_defaults
107107
resource_class: large
108108
steps:
109-
- checkout
110-
- restore_cache:
111-
key: *cache_key
112-
- *yarn_install
113-
- run: yarn bazel build //...
114-
- *save_cache
109+
- checkout
110+
- restore_cache:
111+
key: *cache_key
112+
- *yarn_install
113+
- run:
114+
command: yarn bazel build //...
115+
environment:
116+
# TODO: Remove when pnpm is exclusively used.
117+
ASPECT_RULES_JS_FROZEN_PNPM_LOCK: '1'
118+
- *save_cache
115119

116120
bazel-test:
117121
<<: *job_defaults
118122
resource_class: large
119123
steps:
120-
- checkout
121-
- restore_cache:
122-
key: *cache_key
123-
- *yarn_install
124-
- run: yarn bazel test --test_tag_filters=-lint,-e2e,-audit //...
125-
- *save_cache
126-
- store_artifacts:
127-
path: bazel-testlogs/
128-
- store_artifacts:
129-
path: bazel-testlogs/scenes/
124+
- checkout
125+
- restore_cache:
126+
key: *cache_key
127+
- *yarn_install
128+
- run:
129+
command: yarn bazel test --test_tag_filters=-lint,-e2e,-audit //...
130+
environment:
131+
# TODO: Remove when pnpm is exclusively used.
132+
ASPECT_RULES_JS_FROZEN_PNPM_LOCK: '1'
133+
- *save_cache
134+
- store_artifacts:
135+
path: bazel-testlogs/
136+
- store_artifacts:
137+
path: bazel-testlogs/scenes/
130138

131139
bazel-lint:
132140
<<: *job_defaults
133141
resource_class: large
134142
steps:
135-
- checkout
136-
- restore_cache:
137-
key: *cache_key
138-
- *yarn_install
139-
- run: yarn bazel test --test_tag_filters=+lint //...
140-
- *save_cache
141-
- store_artifacts:
142-
path: bazel-testlogs/
143-
- store_artifacts:
144-
path: bazel-testlogs/scenes/
143+
- checkout
144+
- restore_cache:
145+
key: *cache_key
146+
- *yarn_install
147+
- run: yarn bazel test --test_tag_filters=+lint //...
148+
- *save_cache
149+
- store_artifacts:
150+
path: bazel-testlogs/
151+
- store_artifacts:
152+
path: bazel-testlogs/scenes/
145153

146154
bazel-lighthouse_audits:
147155
<<: *job_defaults
148156
resource_class: xlarge
149157
steps:
150-
- checkout
151-
- restore_cache:
152-
key: *cache_key
153-
- *yarn_install
154-
- run: yarn bazel test --test_tag_filters=+audit //...
155-
- *save_cache
156-
- store_artifacts:
157-
path: bazel-testlogs/
158-
- store_artifacts:
159-
path: bazel-testlogs/scenes/
158+
- checkout
159+
- restore_cache:
160+
key: *cache_key
161+
- *yarn_install
162+
- run: yarn bazel test --test_tag_filters=+audit //...
163+
- *save_cache
164+
- store_artifacts:
165+
path: bazel-testlogs/
166+
- store_artifacts:
167+
path: bazel-testlogs/scenes/
160168

161169
workflows:
162170
version: 2
163171
default_workflow:
164172
jobs:
165-
- lint
166-
- build
167-
- test
168-
- lighthouse_audits:
169-
requires:
170-
- build
171-
- bazel-build
172-
- bazel-test
173-
- bazel-lighthouse_audits
174-
- bazel-lint
173+
- lint
174+
- build
175+
- test
176+
- lighthouse_audits:
177+
requires:
178+
- build
179+
- bazel-build
180+
- bazel-test
181+
- bazel-lighthouse_audits
182+
- bazel-lint

0 commit comments

Comments
 (0)