From 386f18e1fbfe03d380af084eaa6338c0305a0f14 Mon Sep 17 00:00:00 2001 From: Kristiyan Kostadinov Date: Thu, 10 Oct 2024 10:34:01 +0200 Subject: [PATCH] fix: errors when reading optional queries Some optional queries were incorrectly marked as required which was throwing runtime errors. --- src/app/pages/component-sidenav/component-sidenav.html | 2 +- src/app/pages/component-sidenav/component-sidenav.ts | 6 +++--- src/app/pages/component-viewer/component-viewer.ts | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/app/pages/component-sidenav/component-sidenav.html b/src/app/pages/component-sidenav/component-sidenav.html index 52e86144..489d733f 100644 --- a/src/app/pages/component-sidenav/component-sidenav.html +++ b/src/app/pages/component-sidenav/component-sidenav.html @@ -10,7 +10,7 @@ }
- +
diff --git a/src/app/pages/component-sidenav/component-sidenav.ts b/src/app/pages/component-sidenav/component-sidenav.ts index 077ccdcb..ada233dc 100644 --- a/src/app/pages/component-sidenav/component-sidenav.ts +++ b/src/app/pages/component-sidenav/component-sidenav.ts @@ -82,7 +82,7 @@ const SMALL_WIDTH_BREAKPOINT = 959; ], }) export class ComponentSidenav implements OnInit, OnDestroy { - readonly sidenav = viewChild.required(MatSidenav); + readonly sidenav = viewChild(MatSidenav); params: Observable | undefined; isExtraScreenSmall: Observable; isScreenSmall: Observable; @@ -120,8 +120,8 @@ export class ComponentSidenav implements OnInit, OnDestroy { this.subscriptions.unsubscribe(); } - toggleSidenav(sidenav: MatSidenav): Promise { - return sidenav.toggle(); + toggleSidenav(): void { + this.sidenav()?.toggle(); } } diff --git a/src/app/pages/component-viewer/component-viewer.ts b/src/app/pages/component-viewer/component-viewer.ts index cc596e4e..0b00ceb8 100644 --- a/src/app/pages/component-viewer/component-viewer.ts +++ b/src/app/pages/component-viewer/component-viewer.ts @@ -94,7 +94,7 @@ export class ComponentViewer implements OnDestroy { */ @Directive() export class ComponentBaseView implements OnInit, OnDestroy { - readonly tableOfContents = viewChild.required('toc'); + readonly tableOfContents = viewChild('toc'); readonly viewers = viewChildren(DocViewer); showToc: Observable;