Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Commit 0ab73bd

Browse files
committed
fix(list): dense lists cut off descenders of letters like gjqpy
update demo to include letters with descenders fix demo layout on mobile Fixes #8890
1 parent d537d25 commit 0ab73bd

File tree

4 files changed

+19
-21
lines changed

4 files changed

+19
-21
lines changed

src/components/list/demoBasicUsage/index.html

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div ng-controller="AppCtrl" ng-cloak layout-gt-sm="row" layout="column">
1+
<div ng-controller="AppCtrl" ng-cloak layout-gt-sm="row">
22

33
<div flex-gt-sm="50" flex>
44

@@ -35,9 +35,8 @@ <h3>{{ todos[0].who }}</h3>
3535
<div class="md-list-item-text">
3636
<h3>{{ todos[0].who }}</h3>
3737
<p>
38-
Secondary line text Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nam massa quam.
39-
Nulla metus metus, ullamcorper vel, tincidunt sed, euismod in, nibh. Quisque volutpat condimentum
40-
velit. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos.
38+
Secondary line text Lorem ipsum dolor sit amet, consectetur adipiscing elit.
39+
Nam massa quam. Nulla metus metus, ullamcorper vel, tincidunt sed.
4140
</p>
4241
</div>
4342
</md-list-item>
@@ -46,9 +45,8 @@ <h3>{{ todos[0].who }}</h3>
4645
<div class="md-list-item-text">
4746
<h3>{{ todos[1].who }}</h3>
4847
<p>
49-
Secondary line text Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nam massa quam.
50-
Nulla metus metus, ullamcorper vel, tincidunt sed, euismod in, nibh. Quisque volutpat condimentum
51-
velit. Class aptent taciti sociosqu ad litra torquent per conubia nostra, per inceptos himenaeos.
48+
Secondary line text Lorem ipsum dolor sit amet, consectetur adipiscing elit.
49+
Nam massa quam. Nulla metus metus, ullamcorper vel, tincidunt sed.
5250
</p>
5351
</div>
5452
</md-list-item>
@@ -108,9 +106,9 @@ <h3>{{ todos[0].who }}</h3>
108106
<div class="md-list-item-text">
109107
<h3>{{ todos[0].who }}</h3>
110108
<p>
111-
Secondary line text Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nam massa quam.
112-
Nulla metus metus, ullamcorper vel, tincidunt sed, euismod in, nibh. Quisque volutpat condimentum
113-
velit. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos.
109+
Secondary line text Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nam massa
110+
quam. Nulla metus metus, ullamcorper vel, tincidunt sed, euismod in, nibh. Quisque
111+
volutpat condimentum velit.
114112
</p>
115113
</div>
116114
</md-list-item>
@@ -119,9 +117,9 @@ <h3>{{ todos[0].who }}</h3>
119117
<div class="md-list-item-text">
120118
<h3>{{ todos[1].who }}</h3>
121119
<p>
122-
Secondary line text Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nam massa quam.
123-
Nulla metus metus, ullamcorper vel, tincidunt sed, euismod in, nibh. Quisque volutpat condimentum
124-
velit. Class aptent taciti sociosqu ad litra torquent per conubia nostra, per inceptos himenaeos.
120+
Secondary line text Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nam massa
121+
quam. Nulla metus metus, ullamcorper vel, tincidunt sed, euismod in, nibh. Quisque
122+
volutpat condimentum velit.
125123
</p>
126124
</div>
127125
</md-list-item>

src/components/list/demoBasicUsage/script.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@ angular.module('listDemo1', ['ngMaterial'])
4242
$scope.todos = [
4343
{
4444
face : imagePath,
45-
what: 'Brunch this weekend?',
46-
who: 'Min Li Chan',
45+
what: 'My quirky, joyful porg',
46+
who: 'Kaguya w/ #qjporg',
4747
when: '3:08PM',
48-
notes: " I'll be in your neighborhood doing errands"
48+
notes: " I was lucky to find a quirky, joyful porg!"
4949
},
5050
{
5151
face : imagePath,
Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
md-divider {
2-
margin-top: 10px;
3-
margin-bottom: 0;
2+
margin-top: 10px;
3+
margin-bottom: 0;
44
}
5-

src/components/list/list.scss

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
$dense-baseline-grid: $baseline-grid / 2 !default;
22

3-
$list-h3-margin: 0 0 0px 0 !default;
3+
$list-h3-margin: 0 0 0 0 !default;
44
$list-h4-margin: 3px 0 1px 0 !default;
55
$list-h4-font-weight: 400 !default;
66
$list-header-line-height: 1.2em !default;
@@ -56,7 +56,7 @@ md-list {
5656
@include ie11-min-height-flexbug($list-item-dense-height);
5757

5858

59-
// Layout for controls in primary or secondary divs, or auto-infered first child
59+
// Layout for controls in primary or secondary divs, or auto-inferred first child
6060

6161
md-icon:first-child {
6262
width: $list-item-dense-primary-icon-width;
@@ -89,6 +89,7 @@ md-list {
8989
p {
9090
line-height: $list-item-dense-line-height;
9191
font-size: $list-item-dense-font-size;
92+
padding-bottom: 4px;
9293
}
9394

9495
h3 {

0 commit comments

Comments
 (0)