Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Commit 0f3ef64

Browse files
ThomasBurlesonmmalerba
authored andcommitted
chore(release): fix duplicate keys in firebase.json (#10470)
1 parent 6c209b9 commit 0f3ef64

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

release.js

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@
279279
replaceBaseHref('latest');
280280

281281
//-- update firebase.json file
282-
writeFirebaseJson();
282+
updateFirebaseJson();
283283
exec([ 'git commit --amend --no-edit -a' ], options);
284284
done();
285285

@@ -292,18 +292,20 @@
292292
'cd ..'
293293
);
294294

295-
function writeFirebaseJson () {
295+
function updateFirebaseJson () {
296296
fs.writeFileSync(options.cwd + '/firebase.json', getFirebaseJson());
297297
function getFirebaseJson () {
298-
var json = require(options.cwd + '/firebase.json');
299-
json.rewrites = json.rewrites || [];
300-
switch (json.rewrites.length) {
298+
var json = require(options.cwd + '/firebase.json');
299+
json.hosting.rewrites = json.hosting.rewrites || [];
300+
var rewrites = json.hosting.rewrites;
301+
302+
switch (rewrites.length) {
301303
case 0:
302-
json.rewrites.push(getRewrite('HEAD'));
304+
rewrites.push(getRewrite('HEAD'));
303305
case 1:
304-
json.rewrites.push(getRewrite('latest'));
306+
rewrites.push(getRewrite('latest'));
305307
default:
306-
json.rewrites.push(getRewrite(newVersion));
308+
rewrites.push(getRewrite(newVersion));
307309
}
308310
return JSON.stringify(json, null, 2);
309311
function getRewrite (str) {

0 commit comments

Comments
 (0)