fix(mdTooltip): Tooltip role (#10052)

bradrich · mmalerba · commit 7563b4769bea · 2016-12-06T15:27:04.000-08:00
The tooltip role was being assigned to an element that is being detached and not re-attached, causing an a11y issue. The tooltip role is now being assigned to the panel element through the `role` attribute. Fixes #10045
diff --git a/src/components/tooltip/tooltip.js b/src/components/tooltip/tooltip.js
@@ -89,7 +89,6 @@ function MdTooltipDirective($timeout, $window, $$rAF, $document, $interpolate,
 
     // Remove the element from its current DOM position.
     element.detach();
-    element.attr('role', 'tooltip');
 
     updatePosition();
     bindEvents();
@@ -385,7 +384,9 @@ function MdTooltipDirective($timeout, $window, $$rAF, $document, $interpolate,
         panelRef = $mdPanel.create(panelConfig);
       }
 
-      panelRef.open();
+      panelRef.open().then(function() {
+        panelRef.panelEl.attr('role', 'tooltip');
+      });
     }
 
     function hideTooltip() {

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,6 @@ function MdTooltipDirective($timeout, $window, $$rAF, $document, $interpolate,`
`89`	`89`
`90`	`90`	`// Remove the element from its current DOM position.`
`91`	`91`	`element.detach();`
`92`		`- element.attr('role', 'tooltip');`
`93`	`92`
`94`	`93`	`updatePosition();`
`95`	`94`	`bindEvents();`
`@@ -385,7 +384,9 @@ function MdTooltipDirective($timeout, $window, $$rAF, $document, $interpolate,`
`385`	`384`	`panelRef = $mdPanel.create(panelConfig);`
`386`	`385`	`}`
`387`	`386`
`388`		`- panelRef.open();`
	`387`	`+ panelRef.open().then(function() {`
	`388`	`+ panelRef.panelEl.attr('role', 'tooltip');`
	`389`	`+ });`
`389`	`390`	`}`
`390`	`391`
`391`	`392`	`function hideTooltip() {`