chore: upgrade to Angular v6 and RxJS v6 (#87)

Author: CaerusKaru

karma-test-shim.js

@@ -58,6 +58,7 @@ System.config({
   packages: {
     // Thirdparty barrels.
     'rxjs': {main: 'index'},
+    'rxjs/operators': {main: 'index'},
 
     // Set the default extension for the root package, because otherwise the demo-app can't
     // be built within the production mode. Due to missing file extensions.

npm-shrinkwrap.json

@@ -27,52 +27,52 @@
     "Jeff Whelpley <[email protected]>"
   ],
   "devDependencies": {
-    "@angular/animations": "^5.2.1",
-    "@angular/common": "^5.2.1",
-    "@angular/compiler": "^5.2.1",
-    "@angular/compiler-cli": "^5.2.1",
-    "@angular/core": "^5.2.1",
-    "@angular/http": "^5.2.1",
-    "@angular/platform-browser": "^5.2.1",
-    "@angular/platform-browser-dynamic": "^5.2.1",
-    "@angular/platform-server": "^5.2.1",
-    "@types/express": "^4.11.0",
-    "@types/jasmine": "^2.8.4",
+    "@angular/animations": "^6.0.0",
+    "@angular/common": "^6.0.0",
+    "@angular/compiler": "^6.0.0",
+    "@angular/compiler-cli": "^6.0.0",
+    "@angular/core": "^6.0.0",
+    "@angular/http": "^6.0.0",
+    "@angular/platform-browser": "^6.0.0",
+    "@angular/platform-browser-dynamic": "^6.0.0",
+    "@angular/platform-server": "^6.0.0",
+    "@types/express": "^4.11.1",
+    "@types/jasmine": "^2.8.7",
     "@types/minimatch": "^3.0.3",
-    "@types/node": "^8.5.9",
-    "@types/uglify-js": "^2.6.30",
+    "@types/node": "^8.10.14",
+    "@types/uglify-js": "^2.6.31",
     "ajv": "^5.5.2",
     "camelcase": "^4.1.0",
     "concurrently": "^3.5.1",
-    "express": "^4.16.2",
+    "express": "^4.16.3",
     "glob": "^7.1.2",
     "http-server": "^0.10.0",
-    "jasmine": "^2.9.0",
+    "jasmine": "^2.99.0",
     "jasmine-spec-reporter": "^4.1.1",
     "karma": "^1.7.1",
     "karma-chrome-launcher": "^2.2.0",
-    "karma-jasmine": "^1.1.1",
+    "karma-jasmine": "^1.1.2",
     "karma-jasmine-html-reporter": "^0.2.2",
     "karma-sourcemap-loader": "^0.3.7",
     "minimatch": "^3.0.4",
-    "protractor": "^5.2.2",
+    "protractor": "^5.3.2",
     "reflect-metadata": "^0.1.12",
     "rimraf": "^2.6.2",
     "rollup": "~0.41.6",
     "rollup-plugin-alias": "^1.4.0",
-    "rollup-plugin-commonjs": "^8.2.6",
-    "rollup-plugin-node-resolve": "^3.0.2",
+    "rollup-plugin-commonjs": "^8.4.1",
+    "rollup-plugin-node-resolve": "^3.3.0",
     "rollup-plugin-sourcemaps": "^0.4.2",
     "rollup-plugin-uglify": "^2.0.1",
-    "rxjs": "^5.5.6",
+    "rxjs": "^6.1.0",
     "systemjs": "0.19.43",
-    "ts-loader": "^3.2.0",
+    "ts-loader": "^3.5.0",
     "ts-node": "^3.3.0",
-    "tslint": "^5.9.1",
-    "typescript": "^2.6.2",
-    "uglify-js": "^3.3.7",
+    "tslint": "^5.10.0",
+    "typescript": "~2.7.2",
+    "uglify-js": "^3.3.25",
     "webdriver-manager": "^12.0.6",
-    "zone.js": "^0.8.20"
+    "zone.js": "^0.8.26"
   },
   "repository": {
     "type": "git",

package.json

@@ -11,6 +11,7 @@ import {
   EventSelector,
   PrebootAppData,
   PrebootData,
+  PrebootSelection,
   ServerClientRoot,
 } from '../common/preboot.interfaces';
 
@@ -59,7 +60,7 @@ describe('UNIT TEST event.recorder', function() {
   describe('getSelection()', function () {
     it('should return default if no value', function () {
       const node = {};
-      const expected = {
+      const expected: PrebootSelection = {
         start: 0,
         end: 0,
         direction: 'forward'
@@ -71,7 +72,7 @@ describe('UNIT TEST event.recorder', function() {
 
     it('should return selection for older browsers', function () {
       const node = { value: 'foo' };
-      const expected = {
+      const expected: PrebootSelection = {
         start: 3,
         end: 3,
         direction: 'forward'
@@ -86,12 +87,12 @@ describe('UNIT TEST event.recorder', function() {
         value: 'foo',
         selectionStart: 1,
         selectionEnd: 2,
-        selectionDirection: 'reverse'
+        selectionDirection: 'backward'
       };
-      const expected = {
+      const expected: PrebootSelection = {
         start: 1,
         end: 2,
-        direction: 'reverse'
+        direction: 'backward'
       };
 
       const actual = getSelection(node as HTMLInputElement);

src/lib/api/event.recorder.spec.ts

@@ -13,7 +13,7 @@ import {
   DomEvent,
   PrebootWindow,
   ServerClientRoot,
-  PrebootSelection,
+  PrebootSelection, PrebootSelectionDirection,
 } from '../common/preboot.interfaces';
 import {getNodeKeyForPreboot} from '../common/get-node-key';
 
@@ -313,7 +313,7 @@ export function getSelection(node: HTMLInputElement): PrebootSelection {
   node = node || {} as HTMLInputElement;
 
   const nodeValue = node.value || '';
-  const selection = {
+  const selection: PrebootSelection = {
     start: nodeValue.length,
     end: nodeValue.length,
     direction: 'forward'
@@ -324,7 +324,8 @@ export function getSelection(node: HTMLInputElement): PrebootSelection {
     if (node.selectionStart || node.selectionStart === 0) {
       selection.start = node.selectionStart;
       selection.end = node.selectionEnd ? node.selectionEnd : 0;
-      selection.direction = node.selectionDirection ? node.selectionDirection : '';
+      selection.direction = node.selectionDirection ?
+        node.selectionDirection as PrebootSelectionDirection : 'none';
     }
   } catch (ex) {}
 

src/lib/api/event.recorder.ts

@@ -63,10 +63,12 @@ export interface PrebootEventListener {
   handler: EventListener;
 }
 
+export type PrebootSelectionDirection = 'forward' | 'backward' | 'none';
+
 export interface PrebootSelection {
   start: number;
   end: number;
-  direction: string;
+  direction: PrebootSelectionDirection;
 }
 
 // object that contains all data about the currently active node in the DOM (i.e. that has focus)

src/lib/common/preboot.interfaces.ts

@@ -21,8 +21,8 @@
     "universal"
   ],
   "peerDependencies": {
-    "@angular/common": "^5.0.0",
-    "@angular/core": "^5.0.0"
+    "@angular/common": "^6.0.0",
+    "@angular/core": "^6.0.0"
   },
   "repository": {
     "type": "git",

src/lib/package.json

@@ -14,8 +14,7 @@ import {
   PLATFORM_ID
 } from '@angular/core';
 import {DOCUMENT, isPlatformBrowser, isPlatformServer} from '@angular/common';
-import {take} from 'rxjs/operators/take';
-import {filter} from 'rxjs/operators/filter';
+import {filter, take} from 'rxjs/operators';
 
 import {EventReplayer} from './api/event.replayer';
 import {PREBOOT_NONCE} from './common/tokens';

src/lib/provider.ts

@@ -78,8 +78,6 @@
       ["xdescribe"],
       {"name": "Object.assign", "message": "Use the spread operator instead."}
     ],
-    // Disallows importing the whole RxJS library. Submodules can be still imported.
-    "import-blacklist": [true, "rxjs", "rxjs/operators"],
     // Avoids inconsistent linebreak styles in source files. Forces developers to use LF linebreaks.
     "linebreak-style": [true, "LF"],
     // Namespaces are no allowed, because of Closure compiler.