Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Commit b7681c9

Browse files
authored
chore(cleanup): remove cucumber since it is a custom framework (#3919)
closes #3822
1 parent ae76c4f commit b7681c9

File tree

2 files changed

+7
-31
lines changed

2 files changed

+7
-31
lines changed

docs/frameworks.md

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,19 +82,19 @@ exports.config = {
8282
seleniumAddress: 'http://localhost:4444/wd/hub',
8383

8484
baseUrl: 'https://angularjs.org/',
85-
85+
8686
capabilities: {
8787
browserName:'chrome'
8888
},
8989

90-
framework: 'custom', // set to "custom" instead of cucumber.
91-
90+
framework: 'custom', // set to "custom" instead of cucumber.
91+
9292
frameworkPath: require.resolve('protractor-cucumber-framework'), // path relative to the current config file
93-
93+
9494
specs: [
9595
'./cucumber/*.feature' // Specs here are the cucumber feature files
9696
],
97-
97+
9898
// cucumber command line options
9999
cucumberOpts: {
100100
require: ['./cucumber/*.js'], // require step definition files before executing features
@@ -115,5 +115,3 @@ Using a Custom Framework
115115
------------------------
116116

117117
Check section [Framework Adapters for Protractor](/lib/frameworks/README.md) specifically [Custom Frameworks](/lib/frameworks/README.md#custom-frameworks)
118-
119-

lib/config.ts

Lines changed: 2 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
import {PluginConfig} from './plugins';
22

33
export interface Config {
4+
[key: string]: any;
5+
46
// ---------------------------------------------------------------------------
57
// ----- How to connect to Browser Drivers -----------------------------------
68
// ---------------------------------------------------------------------------
@@ -560,30 +562,6 @@ export interface Config {
560562
*/
561563
mochaOpts?: {[key: string]: any; ui?: string; reporter?: string;};
562564

563-
/**
564-
* Options to be passed to Cucumber (when set up as a custom framework).
565-
*/
566-
cucumberOpts?: {
567-
[key: string]: any;
568-
/**
569-
* Require files before executing the features.
570-
*/
571-
require?: string[] | string;
572-
/**
573-
* Only execute the features or scenarios with tags matching @dev.
574-
* This may be an array of strings to specify multiple tags to include.
575-
*/
576-
tags?: string;
577-
/**
578-
* How to format features (default: progress)
579-
*/
580-
format?: string[] | string;
581-
/**
582-
* Quickly scan your features without actually running them.
583-
*/
584-
dryRun?: boolean;
585-
};
586-
587565
/**
588566
* See docs/plugins.md
589567
*/

0 commit comments

Comments
 (0)