Issues minifying ts2dart

[dariajung]

• TypeScript objects not being typed to classes/interfaces defined in typescript.d.ts (in want of more generic/flexible types)
  • ie: n: ts.ModifiersArray vs n: {flags: number} in base.ts line 61
• Typing problems - if maybeVisitTypeArguments takes a type not externally declared, typeArguments get renamed, but adding a more strict typing like ts.ExpressionWithTypeArguments brings up an error when passed something like an object of type ts.CallExpression
  • error TS2345: Argument of type 'CallExpression' is not assignable to parameter of type 'ExpressionWithTypeArguments'.

Breakage, in cases like these:

return {fileName, qname};

---

function getFileAndName(): { fileName: string, qname: string } // rename properties here? {
    var fileName = 'hello';
    var qname = 'world';
    return { fileName, qname }; // ShortPropertyAssignment
}

A TypeLiteral node is comprised of

• First Punctuation
• SyntaxList
• CloseBraceToken

SyntaxListis where the interesting bit could happen:

• PropertySignature
  • Identifier
  • ColonToken
  • StringKeyword

Another scenario:

function getFileAndName(): { fileName: string, qname: string } {
    var fileName = 'hello';
    var blah = 'world';
    return { fileName, qname: blah };
}

The current algorithm contextEmit will rename qname and blah because they are both identifiers, when we only want to rename qname.

[dariajung]

case ts.SyntaxKind.PropertySignature: {
        if (node.parent.kind === ts.SyntaxKind.TypeLiteral) {
          return this.contextEmit(node, true);
        }
        return this.contextEmit(node);
      }