fix(@nguniversal/builders): bundle critters in common engine.

alan-agius4 · alan-agius4 · commit 03285c9978cd · 2021-02-08T14:08:13.000+01:00
critters is shipped with ES2015 this that we cannot extend it when we use the UMD because a downlevelled class cannot extend an ES2015 class as it will cause `cannot be invoked without 'new'` With this change, critters will be included in the UMD bundle and downelevelled which would result in us being able to extend it. Closes #1970 (cherry picked from commit 68b392a)
diff --git a/modules/common/BUILD.bazel b/modules/common/BUILD.bazel
@@ -28,6 +28,7 @@ ng_package(
     deps = [
         ":common",
         "//modules/common/engine",
+        "@npm//critters",
     ],
 )
 
diff --git a/tools/defaults.bzl b/tools/defaults.bzl
@@ -79,7 +79,6 @@ GLOBALS = {
     "@nguniversal/aspnetcore-engine/tokens": "nguniversal.aspnetcoreEngine.tokens",
     "@nguniversal/express-engine/tokens": "nguniversal.expressEngine.tokens",
     "@nguniversal/hapi-engine/tokens": "nguniversal.hapiEngine.tokens",
-    "critters": "critters",
     "express": "express",
     "fs": "fs",
     "@hapi/hapi": "hapi.hapi",

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ ng_package(`
`28`	`28`	`deps = [`
`29`	`29`	`":common",`
`30`	`30`	`"//modules/common/engine",`
	`31`	`+ "@npm//critters",`
`31`	`32`	`],`
`32`	`33`	`)`
`33`	`34`