Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

Commit 1d96e79

Browse files
committed
build: mark critters dependencies as external
Currently we are bunding critters and it's deps into our bundles, but we only need to bundle critters. We need to bundle critters because in v12 we still use ES5 UMDs and critters is in ES2015 and therefore we cannot extend it's class.
1 parent 70d2b37 commit 1d96e79

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

tools/defaults.bzl

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,14 @@ GLOBALS = {
8989
"@hapi/hapi": "hapi.hapi",
9090
"rxjs": "rxjs",
9191
"rxjs/operators": "rxjs.operators",
92+
# The below are deps of critters which we do bundle because it's shipped in ES2015
93+
# and we cannot extend otherwise due to UMDs are in ES5
94+
"css-select": "cssSselect",
95+
"chalk": "chalk",
96+
"parse5": "parse5",
97+
"parse5-htmlparser2-tree-adapter": "parse5",
98+
"postcss": "postcss",
99+
"pretty-bytes": "prettyBytes",
92100
}
93101

94102
def ng_module(name, tsconfig = None, testonly = False, deps = [], bundle_dts = True, **kwargs):

0 commit comments

Comments
 (0)