Skip to content
This repository was archived by the owner on Nov 22, 2024. It is now read-only.

Commit 666b879

Browse files
committed
fix: don't bundle common engine in hapi and express engine
The common engine is a direct depedency and hence bundle it is redundant.
1 parent e855870 commit 666b879

File tree

3 files changed

+14
-0
lines changed

3 files changed

+14
-0
lines changed

modules/builders/BUILD.bazel

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ jasmine_node_test(
6464
"@npm//shelljs",
6565
"@npm//node-fetch",
6666
"@npm//zone.js",
67+
"//modules/common:npm_package",
6768
"//modules/express-engine:npm_package",
6869
":npm_package",
6970
] + glob([

modules/builders/testing/utils.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,16 @@ export async function createArchitect(root: Path) {
7171
);
7272
}
7373

74+
const ngUniveralCommonmNodePackages = path.join(ngUniversalNodePackages, 'common');
75+
if (!existsSync(ngUniveralCommonmNodePackages)) {
76+
cp(
77+
'-ru',
78+
path.join(
79+
require.resolve('nguniversal/modules/common/npm_package/package.json'), '../'),
80+
ngUniveralCommonmNodePackages,
81+
);
82+
}
83+
7484
const { workspace } = await workspaces.readWorkspace(
7585
workspaceSysPath,
7686
workspaces.createWorkspaceHost(host),

tools/defaults.bzl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,9 @@ GLOBALS = {
7272
"@angular/platform-browser": "ng.platformBrowser",
7373
"@angular/platform-browser-dynamic": "ng.platformBrowserDynamic",
7474
"@angular/platform-server": "ng.platformServer",
75+
"@nguniversal/common": "nguniversal.common",
76+
"@nguniversal/common/engine": "nguniversal.common.engine",
77+
"@nguniversal/common/tokens": "nguniversal.common.tokens",
7578
"@nguniversal/aspnetcore-engine/tokens": "nguniversal.aspnetcoreEngine.tokens",
7679
"@nguniversal/express-engine/tokens": "nguniversal.expressEngine.tokens",
7780
"@nguniversal/hapi-engine/tokens": "nguniversal.hapiEngine.tokens",

0 commit comments

Comments
 (0)