test: add test and fix clang-format formatted files

Adds automated Travis CI test to ensure TypeScript files are formatted
with `clang-format`. If any files are unformatted, and error message
stating "Files not formatted; please run 'yarn format'" is given.

Also formats existing files to pass this new test.

PR Closes #373

Author: ayazhafiz

.travis.yml

@@ -16,6 +16,7 @@ script:
   - ./scripts/lint.sh
   - ./scripts/build.sh
   - ./scripts/test.sh
+  - ./scripts/format.sh && git diff --diff-filter=ACMRT --exit-code || (echo "Files not formatted; please run 'yarn format'." && exit 1)
 
 after_script:
   - ./scripts/cleanup.sh

client/src/extension.ts

@@ -7,21 +7,20 @@
  */
 
 import * as path from 'path';
+import {ExtensionContext, ProgressLocation, window, workspace} from 'vscode';
+import {LanguageClient, LanguageClientOptions, RevealOutputChannelOn, ServerOptions, TransportKind} from 'vscode-languageclient';
 
-import { workspace, ExtensionContext, window, ProgressLocation } from 'vscode';
-import { LanguageClient, LanguageClientOptions, ServerOptions, TransportKind, RevealOutputChannelOn } from 'vscode-languageclient';
-import { projectLoadingNotification } from './protocol';
+import {projectLoadingNotification} from './protocol';
 
 export function activate(context: ExtensionContext) {
-
   // Log file does not yet exist on disk. It is up to the server to create the
   // file.
   const logFile = path.join(context.logPath, 'nglangsvc.log');
 
   // If the extension is launched in debug mode then the debug server options are used
   // Otherwise the run options are used
   const serverOptions: ServerOptions = {
-    run : {
+    run: {
       module: context.asAbsolutePath(path.join('server', 'server.js')),
       transport: TransportKind.ipc,
       args: [
@@ -39,8 +38,10 @@ export function activate(context: ExtensionContext) {
       module: context.asAbsolutePath(path.join('server', 'out', 'server.js')),
       transport: TransportKind.ipc,
       args: [
-        '--logFile', logFile,
-        '--logVerbosity', 'verbose',
+        '--logFile',
+        logFile,
+        '--logVerbosity',
+        'verbose',
       ],
       options: {
         env: {
@@ -80,35 +81,35 @@ export function activate(context: ExtensionContext) {
   };
 
   // Create the language client and start the client.
-  const forceDebug =  !!process.env['NG_DEBUG'];
-  const client = new LanguageClient(
-    'Angular Language Service', serverOptions, clientOptions, forceDebug);
+  const forceDebug = !!process.env['NG_DEBUG'];
+  const client =
+      new LanguageClient('Angular Language Service', serverOptions, clientOptions, forceDebug);
   const disposable = client.start();
 
   // Push the disposable to the context's subscriptions so that the
   // client can be deactivated on extension deactivation
   context.subscriptions.push(disposable);
 
-  client.onReady().then(()=>{
-
-    const projectLoadingTasks = new Map<string, { resolve: () => void }>();
+  client.onReady().then(() => {
+    const projectLoadingTasks = new Map<string, {resolve: () => void}>();
 
     client.onNotification(projectLoadingNotification.start, (projectName: string) => {
-      window.withProgress({
-        location: ProgressLocation.Window,
-        title: 'Initializing Angular language features',
-      }, () => new Promise((resolve) => {
-        projectLoadingTasks.set(projectName, { resolve });
-      }));
+      window.withProgress(
+          {
+            location: ProgressLocation.Window,
+            title: 'Initializing Angular language features',
+          },
+          () => new Promise((resolve) => {
+            projectLoadingTasks.set(projectName, {resolve});
+          }));
     });
-  
+
     client.onNotification(projectLoadingNotification.finish, (projectName: string) => {
-        const task = projectLoadingTasks.get(projectName);
-        if(task){
-          task.resolve();
-          projectLoadingTasks.delete(projectName);
-        }
+      const task = projectLoadingTasks.get(projectName);
+      if (task) {
+        task.resolve();
+        projectLoadingTasks.delete(projectName);
+      }
     });
-
   });
 }

client/src/protocol.ts

@@ -6,9 +6,9 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import { NotificationType } from 'vscode-languageclient';
+import {NotificationType} from 'vscode-languageclient';
 
 export const projectLoadingNotification = {
-  start: new NotificationType<string,string>('angular-language-service/projectLoadingStart'),
-  finish: new NotificationType<string,string>('angular-language-service/projectLoadingFinish')
+  start: new NotificationType<string, string>('angular-language-service/projectLoadingStart'),
+  finish: new NotificationType<string, string>('angular-language-service/projectLoadingFinish')
 };

integration/e2e/definition.test.ts

@@ -1,6 +1,7 @@
-import * as vscode from 'vscode';
-import * as path from 'path';
 import * as assert from 'assert';
+import * as path from 'path';
+import * as vscode from 'vscode';
+
 import {activate} from './helper';
 
 const DEFINITION_COMMAND = 'vscode.executeDefinitionProvider';
@@ -20,10 +21,7 @@ describe('Angular LS', () => {
     // For a complete list of standard commands, see
     // https://code.visualstudio.com/api/references/commands
     const definitions = await vscode.commands.executeCommand(
-      DEFINITION_COMMAND,
-      docUri,
-      position
-    ) as vscode.Location[];
+                            DEFINITION_COMMAND, docUri, position) as vscode.Location[];
     assert.equal(definitions.length, 1);
     const def = definitions[0];
     assert.equal(def.uri.fsPath, docPath);  // in the same document

integration/e2e/helper.ts

@@ -1,5 +1,5 @@
-import * as vscode from 'vscode';
 import * as path from 'path';
+import * as vscode from 'vscode';
 
 function sleep(ms: number) {
   return new Promise(resolve => setTimeout(resolve, ms));
@@ -11,10 +11,8 @@ export async function activate(uri: vscode.Uri) {
   try {
     const doc = await vscode.workspace.openTextDocument(uri);
     const editor = await vscode.window.showTextDocument(doc);
-    await sleep(2000); // Wait for server activation
-  }
-  catch (e) {
+    await sleep(2000);  // Wait for server activation
+  } catch (e) {
     console.error(e);
   }
-
 }

integration/e2e/index.ts

@@ -3,10 +3,6 @@ import * as testRunner from 'vscode/lib/testrunner';
 // This is the entry point of the test.
 // The test runner provided by vscode uses Mocha.
 // Check output in `Debug Console` of the main vscode window.
-testRunner.configure({
-    ui: 'bdd',
-    useColors: true,
-    timeout: 100000
-});
+testRunner.configure({ui: 'bdd', useColors: true, timeout: 100000});
 
 module.exports = testRunner;