Skip to content

Commit 0676697

Browse files
kyliauKeen Yee Liau
authored andcommitted
fix: ngcc progress not reported
ngcc progress is supposed to be reported to the client, but since the child process is not silenced, stdio got inherited from the parent process. As a result, ngcc progress shows up in the Output panel of Angular language service instead of the status bar in vscode.
1 parent 99c4b37 commit 0676697

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

server/src/ngcc.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ export async function resolveAndRunNgcc(tsconfig: string, progress: Progress): P
4747
],
4848
{
4949
cwd: resolve(cwd),
50+
silent: true, // pipe stderr and stdout so that we can report progress
5051
});
5152

5253
let stderr = '';

0 commit comments

Comments
 (0)