Skip to content
This repository was archived by the owner on Nov 21, 2025. It is now read-only.

Commit 0ed47df

Browse files
author
Keen Yee Liau
committed
test: Add e2e test for definition
This commit adds an E2E test that brings up VSCode instance and launch the extension, The test could intercept results from the extension and assert that they are as expected.
1 parent ea332ee commit 0ed47df

File tree

15 files changed

+696
-697
lines changed

15 files changed

+696
-697
lines changed

‎.gitignore‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
.vscode-test
2+
.DS_Store
13
node_modules
24
client/node_modules/
35
client/out/
@@ -6,5 +8,4 @@ server/out
68
integration/out
79
dist/
810
**/.idea/
9-
.DS_Store
1011
**/tsconfig.tsbuildinfo

‎.vscode/launch.json‎

Lines changed: 48 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,48 @@
1-
// A launch configuration that compiles the extension and then opens it inside a new window
2-
{
3-
"version": "0.2.0",
4-
"configurations": [
5-
{
6-
"type": "extensionHost",
7-
"request": "launch",
8-
"name": "Launch Client",
9-
"runtimeExecutable": "${execPath}",
10-
"args": ["--extensionDevelopmentPath=${workspaceRoot}"],
11-
"outFiles": ["${workspaceRoot}/client/out/**/*.js"],
12-
"preLaunchTask": {
13-
"type": "npm",
14-
"script": "watch"
15-
}
16-
},
17-
{
18-
"type": "node",
19-
"request": "attach",
20-
"name": "Attach to Server",
21-
"port": 6009,
22-
"restart": true,
23-
"outFiles": ["${workspaceRoot}/server/out/**/*.js"]
24-
},
25-
{
26-
"name": "Language Server E2E Test",
27-
"type": "extensionHost",
28-
"request": "launch",
29-
"runtimeExecutable": "${execPath}",
30-
"args": [
31-
"--extensionDevelopmentPath=${workspaceRoot}",
32-
"--extensionTestsPath=${workspaceRoot}/client/out/test",
33-
"${workspaceRoot}/client/testFixture"
34-
],
35-
"outFiles": ["${workspaceRoot}/client/out/test/**/*.js"]
36-
}
37-
],
38-
"compounds": [
39-
{
40-
"name": "Client + Server",
41-
"configurations": ["Launch Client", "Attach to Server"]
42-
}
43-
]
44-
}
1+
// A launch configuration that compiles the extension and then opens it inside a new window
2+
{
3+
"version": "0.2.0",
4+
"configurations": [
5+
{
6+
"type": "extensionHost",
7+
"request": "launch",
8+
"name": "Launch Client",
9+
"runtimeExecutable": "${execPath}",
10+
"args": ["--extensionDevelopmentPath=${workspaceRoot}"],
11+
"outFiles": ["${workspaceRoot}/client/out/**/*.js"],
12+
"preLaunchTask": {
13+
"type": "npm",
14+
"script": "watch"
15+
}
16+
},
17+
{
18+
"type": "node",
19+
"request": "attach",
20+
"name": "Attach to Server",
21+
"port": 6009,
22+
"restart": true,
23+
"outFiles": ["${workspaceRoot}/server/out/**/*.js"]
24+
},
25+
{
26+
"name": "Language Server E2E Test",
27+
"type": "extensionHost",
28+
"request": "launch",
29+
"runtimeExecutable": "${execPath}",
30+
"args": [
31+
"--extensionDevelopmentPath=${workspaceRoot}",
32+
"--extensionTestsPath=${workspaceRoot}/integration/out/e2e",
33+
"${workspaceRoot}/integration/project"
34+
],
35+
"outFiles": ["${workspaceRoot}/integration/out/e2e/*.js"],
36+
"preLaunchTask": {
37+
"type": "npm",
38+
"script": "compile:integration"
39+
}
40+
}
41+
],
42+
"compounds": [
43+
{
44+
"name": "Client + Server",
45+
"configurations": ["Launch Client", "Attach to Server"]
46+
}
47+
]
48+
}

‎.vscode/tasks.json‎

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,33 @@
1-
{
2-
"version": "2.0.0",
3-
"tasks": [
4-
{
5-
"type": "npm",
6-
"script": "compile",
7-
"group": "build",
8-
"presentation": {
9-
"panel": "dedicated",
10-
"reveal": "never"
11-
},
12-
"problemMatcher": [
13-
"$tsc"
14-
]
15-
},
16-
{
17-
"type": "npm",
18-
"script": "watch",
19-
"isBackground": true,
20-
"group": {
21-
"kind": "build",
22-
"isDefault": true
23-
},
24-
"presentation": {
25-
"panel": "dedicated",
26-
"reveal": "never"
27-
},
28-
"problemMatcher": [
29-
"$tsc-watch"
30-
]
31-
}
32-
]
33-
}
1+
{
2+
"version": "2.0.0",
3+
"tasks": [
4+
{
5+
"type": "npm",
6+
"script": "compile",
7+
"group": "build",
8+
"presentation": {
9+
"panel": "dedicated",
10+
"reveal": "never"
11+
},
12+
"problemMatcher": [
13+
"$tsc"
14+
]
15+
},
16+
{
17+
"type": "npm",
18+
"script": "watch",
19+
"isBackground": true,
20+
"group": {
21+
"kind": "build",
22+
"isDefault": true
23+
},
24+
"presentation": {
25+
"panel": "dedicated",
26+
"reveal": "never"
27+
},
28+
"problemMatcher": [
29+
"$tsc-watch"
30+
]
31+
}
32+
]
33+
}

‎client/package.json‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,7 @@
44
"private": true,
55
"author": "Angular",
66
"license": "MIT",
7-
"engines": {
8-
"vscode": "^1.30.0"
9-
},
107
"dependencies": {
118
"vscode-languageclient": "~5.2.1"
12-
},
13-
"devDependencies": {
14-
"vscode": "^1.1.36"
15-
},
16-
"scripts": {
17-
"update-vscode": "vscode-install",
18-
"postinstall": "vscode-install"
199
}
2010
}

‎client/src/extension.ts‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,9 @@ export function activate(context: ExtensionContext) {
7171
}
7272

7373
// Create the language client and start the client.
74-
const client = new LanguageClient('Angular Language Service', serverOptions, clientOptions);
74+
const forceDebug = !!process.env['NG_DEBUG'];
75+
const client = new LanguageClient(
76+
'Angular Language Service', serverOptions, clientOptions, forceDebug);
7577
const disposable = client.start();
7678

7779
// Push the disposable to the context's subscriptions so that the

0 commit comments

Comments
 (0)