Skip to content

Commit 1439441

Browse files
ayazhafizKeen Yee Liau
authored andcommitted
fixup! fix(server): don't skip definitions with a zero-length range
1 parent 2244ceb commit 1439441

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

server/src/server.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,9 @@ const serverHost = new ServerHost();
4343
const projSvc = new ProjectService(serverHost, logger, connection, options);
4444
const {tsProjSvc} = projSvc;
4545

46+
// Empty definition range for files without `scriptInfo`
47+
const EMPTY_RANGE = lsp.Range.create(0, 0, 0, 0);
48+
4649
// Log initialization info
4750
connection.console.info(`Log file: ${logger.getLogFileName()}`);
4851
if (process.env.NG_DEBUG) {
@@ -176,8 +179,7 @@ connection.onDefinition((params: lsp.TextDocumentPositionParams) => {
176179
if (!scriptInfo && d.textSpan.length > 0) {
177180
continue;
178181
}
179-
const ZERO_RANGE = lsp.Range.create(0, 0, 0, 0); // for files without `scriptInfo`
180-
const range = scriptInfo ? tsTextSpanToLspRange(scriptInfo, d.textSpan) : ZERO_RANGE;
182+
const range = scriptInfo ? tsTextSpanToLspRange(scriptInfo, d.textSpan) : EMPTY_RANGE;
181183

182184
const targetUri = filePathToUri(d.fileName);
183185
results.push({

0 commit comments

Comments
 (0)