fix: Use View Engine LS for projects < v9

`ngcc` does not work correctly for Angular projects < version 9, so
automatically switch to View Engine LS when such projects are detected in
the workspace.

Author: kyliau

client/src/client.ts

@@ -14,6 +14,7 @@ import * as lsp from 'vscode-languageclient/node';
 import {ProjectLoadingFinish, ProjectLoadingStart, SuggestStrictMode, SuggestStrictModeParams} from '../common/notifications';
 import {NgccProgress, NgccProgressToken, NgccProgressType} from '../common/progress';
 import {GetComponentsWithTemplateFile, GetTcbRequest, IsInAngularProject} from '../common/requests';
+import {resolve, Version} from '../common/resolver';
 
 import {isInsideComponentDecorator, isInsideInlineTemplateRegion} from './embedded_support';
 import {ProgressReporter} from './progress-reporter';
@@ -314,7 +315,8 @@ function registerProgressHandlers(client: lsp.LanguageClient) {
       client.onProgress(NgccProgressType, NgccProgressToken, async (params: NgccProgress) => {
         const {configFilePath} = params;
         if (!progressReporters.has(configFilePath)) {
-          progressReporters.set(configFilePath, new ProgressReporter());
+          const reporter = new ProgressReporter();
+          progressReporters.set(configFilePath, reporter);
         }
         const reporter = progressReporters.get(configFilePath)!;
         if (params.done) {
@@ -388,7 +390,8 @@ function constructArgs(ctx: vscode.ExtensionContext): string[] {
   const ngProbeLocations = getProbeLocations(ngdk, ctx.extensionPath);
   args.push('--ngProbeLocations', ngProbeLocations.join(','));
 
-  const viewEngine: boolean = config.get('angular.view-engine', false);
+  console.error(vscode.workspace.workspaceFolders);
+  const viewEngine: boolean = config.get('angular.view-engine', !allProjectsSupportIvy());
   if (viewEngine) {
     args.push('--viewEngine');
   }
@@ -432,4 +435,15 @@ function getServerOptions(ctx: vscode.ExtensionContext, debug: boolean): lsp.Nod
       execArgv: debug ? devExecArgv : prodExecArgv,
     },
   };
+}
+
+function allProjectsSupportIvy() {
+  const workspaceFolders = vscode.workspace.workspaceFolders || [];
+  for (const workspaceFolder of workspaceFolders) {
+    const angularCore = resolve('@angular/core', workspaceFolder.uri.fsPath);
+    if (angularCore?.version.greaterThanOrEqual(new Version('9')) === false) {
+      return false;
+    }
+  }
+  return true;
 }

common/resolver.ts

@@ -0,0 +1,100 @@
+/**
+ * @license
+ * Copyright Google Inc. All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.io/license
+ */
+
+import * as fs from 'fs';
+
+/**
+ * Represents a valid node module that has been successfully resolved.
+ */
+export interface NodeModule {
+  name: string;
+  resolvedPath: string;
+  version: Version;
+}
+
+export function resolve(packageName: string, location: string, rootPackage?: string): NodeModule|
+    undefined {
+  rootPackage = rootPackage || packageName;
+  try {
+    const packageJsonPath = require.resolve(`${rootPackage}/package.json`, {
+      paths: [location],
+    });
+    // Do not use require() to read JSON files since it's a potential security
+    // vulnerability.
+    const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
+    const resolvedPath = require.resolve(packageName, {
+      paths: [location],
+    });
+    return {
+      name: packageName,
+      resolvedPath,
+      version: new Version(packageJson.version),
+    };
+  } catch {
+  }
+}
+
+export class Version {
+  readonly major: number;
+  readonly minor: number;
+  readonly patch: number;
+
+  constructor(private readonly versionStr: string) {
+    const [major, minor, patch] = Version.parseVersionStr(versionStr);
+    this.major = major;
+    this.minor = minor;
+    this.patch = patch;
+  }
+
+  greaterThanOrEqual(other: Version): boolean {
+    if (this.major < other.major) {
+      return false;
+    }
+    if (this.major > other.major) {
+      return true;
+    }
+    if (this.minor < other.minor) {
+      return false;
+    }
+    if (this.minor > other.minor) {
+      return true;
+    }
+    return this.patch >= other.patch;
+  }
+
+  toString(): string {
+    return this.versionStr;
+  }
+
+  /**
+   * Converts the specified `versionStr` to its number constituents. Invalid
+   * number value is represented as negative number.
+   * @param versionStr
+   */
+  static parseVersionStr(versionStr: string): [number, number, number] {
+    const [major, minor, patch] = versionStr.split('.').map(parseNonNegativeInt);
+    return [
+      major === undefined ? 0 : major,
+      minor === undefined ? 0 : minor,
+      patch === undefined ? 0 : patch,
+    ];
+  }
+}
+
+/**
+ * Converts the specified string `a` to non-negative integer.
+ * Returns -1 if the result is NaN.
+ * @param a
+ */
+function parseNonNegativeInt(a: string): number {
+  // parseInt() will try to convert as many as possible leading characters that
+  // are digits. This means a string like "123abc" will be converted to 123.
+  // For our use case, this is sufficient.
+  const i = parseInt(a, 10 /* radix */);
+  return isNaN(i) ? -1 : i;
+}

server/src/version_provider.ts

@@ -9,41 +9,12 @@
 import * as fs from 'fs';
 import * as path from 'path';
 
+import {NodeModule, resolve, Version} from '../common/resolver';
+
 const MIN_TS_VERSION = '4.2';
 const MIN_NG_VERSION = '12.0';
 const TSSERVERLIB = 'typescript/lib/tsserverlibrary';
 
-/**
- * Represents a valid node module that has been successfully resolved.
- */
-interface NodeModule {
-  name: string;
-  resolvedPath: string;
-  version: Version;
-}
-
-export function resolve(packageName: string, location: string, rootPackage?: string): NodeModule|
-    undefined {
-  rootPackage = rootPackage || packageName;
-  try {
-    const packageJsonPath = require.resolve(`${rootPackage}/package.json`, {
-      paths: [location],
-    });
-    // Do not use require() to read JSON files since it's a potential security
-    // vulnerability.
-    const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
-    const resolvedPath = require.resolve(packageName, {
-      paths: [location],
-    });
-    return {
-      name: packageName,
-      resolvedPath,
-      version: new Version(packageJson.version),
-    };
-  } catch {
-  }
-}
-
 /**
  * Resolve the node module with the specified `packageName` that satisfies
  * the specified minimum version.
@@ -125,63 +96,3 @@ export function resolveNgLangSvc(probeLocations: string[]): NodeModule {
 export function resolveNgcc(directory: string): NodeModule|undefined {
   return resolve('@angular/compiler-cli/ngcc/main-ngcc.js', directory, '@angular/compiler-cli');
 }
-
-/**
- * Converts the specified string `a` to non-negative integer.
- * Returns -1 if the result is NaN.
- * @param a
- */
-function parseNonNegativeInt(a: string): number {
-  // parseInt() will try to convert as many as possible leading characters that
-  // are digits. This means a string like "123abc" will be converted to 123.
-  // For our use case, this is sufficient.
-  const i = parseInt(a, 10 /* radix */);
-  return isNaN(i) ? -1 : i;
-}
-
-export class Version {
-  readonly major: number;
-  readonly minor: number;
-  readonly patch: number;
-
-  constructor(private readonly versionStr: string) {
-    const [major, minor, patch] = Version.parseVersionStr(versionStr);
-    this.major = major;
-    this.minor = minor;
-    this.patch = patch;
-  }
-
-  greaterThanOrEqual(other: Version): boolean {
-    if (this.major < other.major) {
-      return false;
-    }
-    if (this.major > other.major) {
-      return true;
-    }
-    if (this.minor < other.minor) {
-      return false;
-    }
-    if (this.minor > other.minor) {
-      return true;
-    }
-    return this.patch >= other.patch;
-  }
-
-  toString(): string {
-    return this.versionStr;
-  }
-
-  /**
-   * Converts the specified `versionStr` to its number constituents. Invalid
-   * number value is represented as negative number.
-   * @param versionStr
-   */
-  static parseVersionStr(versionStr: string): [number, number, number] {
-    const [major, minor, patch] = versionStr.split('.').map(parseNonNegativeInt);
-    return [
-      major === undefined ? 0 : major,
-      minor === undefined ? 0 : minor,
-      patch === undefined ? 0 : patch,
-    ];
-  }
-}