fix goToDefinition offset error

Author: Keen Yee Liau

server/src/errors.ts

@@ -33,9 +33,13 @@ export class ErrorCollector {
     if (service) {
       const diagnostics = service.getDiagnostics(fileName);
       if (!diagnostics || !diagnostics.length) {
+        this.connection.sendDiagnostics({
+          uri: document.uri,
+          diagnostics: [],
+        });
         return;
       }
-      if (diagnostics[0].message) {
+      if (diagnostics[0].span) {
         // Backwards compatibility with old ng.Diagnostic[]
         const offsets = ([] as number[]).concat(...diagnostics.map(d => [d.span.start, d.span.end]));
         const positions = this.documents.offsetsToPositions(document, offsets);

server/src/server.ts

@@ -194,16 +194,14 @@ connection.onDefinition((params: lsp.TextDocumentPositionParams) => logErrors(()
       textSpan.start,
       textSpan.start + textSpan.length,
     ]);
-    const originSelectionRange = lsp.Range.create(
-      start.line - 1, start.character - 1, end.line - 1, end.character - 1);
+    const originSelectionRange = lsp.Range.create(start, end);
     return definitions.map((d) => {
       const targetUri = lsp.TextDocumentIdentifier.create(fileNameToUri(d.fileName));
       const [start, end] = documents.offsetsToPositions(targetUri, [
         d.textSpan.start,
         d.textSpan.start + d.textSpan.length,
       ]);
-      const targetRange = lsp.Range.create(
-        start.line - 1, start.character - 1, end.line -1, end.character - 1);
+      const targetRange = lsp.Range.create(start, end);
       return {
         originSelectionRange,
         targetUri : targetUri.uri,