Revert "perf: prevent requests from being sent to the server when outside Angular context"

This reverts commit fcbdf93.

Author: Keen Yee Liau

.vscode/launch.json

@@ -7,12 +7,8 @@
       "request": "launch",
       "name": "Launch Client",
       "runtimeExecutable": "${execPath}",
-      "args": [
-        "--extensionDevelopmentPath=${workspaceFolder}"
-      ],
-      "outFiles": [
-        "${workspaceFolder}/dist/client/*.js"
-      ],
+      "args": ["--extensionDevelopmentPath=${workspaceRoot}"],
+      "outFiles": ["${workspaceRoot}/dist/client/*.js"],
       "preLaunchTask": {
         "type": "npm",
         "script": "watch"
@@ -24,19 +20,7 @@
       "name": "Attach to Server",
       "port": 6009,
       "restart": true,
-      "outFiles": [
-        "${workspaceFolder}/dist/server/*.js"
-      ]
-    },
-    {
-      "type": "node",
-      "request": "attach",
-      "name": "Attach to Jasmine",
-      "port": 9229,
-      "restart": true,
-      "outFiles": [
-        "${workspaceFolder}/dist/**/*.js"
-      ],
+      "outFiles": ["${workspaceRoot}/dist/server/*.js"]
     },
     {
       "name": "Integration test: Attach to server",
@@ -45,9 +29,7 @@
       "skipFiles": [
         "<node_internals>/**"
       ],
-      "outFiles": [
-        "${workspaceFolder}/dist/integration/lsp/*.js"
-      ],
+      "outFiles": ["${workspaceRoot}/dist/integration/lsp/*.js"],
       "type": "node"
     },
     {
@@ -56,13 +38,11 @@
       "request": "launch",
       "runtimeExecutable": "${execPath}",
       "args": [
-        "--extensionDevelopmentPath=${workspaceFolder}",
-        "--extensionTestsPath=${workspaceFolder}/dist/integration/e2e",
-        "${workspaceFolder}/integration/project"
-      ],
-      "outFiles": [
-        "${workspaceFolder}/dist/integration/e2e/*.js"
+        "--extensionDevelopmentPath=${workspaceRoot}",
+        "--extensionTestsPath=${workspaceRoot}/dist/integration/e2e",
+        "${workspaceRoot}/integration/project"
       ],
+      "outFiles": ["${workspaceRoot}/dist/integration/e2e/*.js"],
       "preLaunchTask": {
         "type": "npm",
         "script": "compile:integration"
@@ -72,10 +52,7 @@
   "compounds": [
     {
       "name": "Client + Server",
-      "configurations": [
-        "Launch Client",
-        "Attach to Server"
-      ]
+      "configurations": ["Launch Client", "Attach to Server"]
     }
   ]
-}
+}

client/src/client.ts

@@ -15,7 +15,6 @@ import {ProjectLoadingFinish, ProjectLoadingStart, SuggestIvyLanguageService, Su
 import {NgccProgress, NgccProgressToken, NgccProgressType} from '../common/progress';
 import {GetTcbRequest} from '../common/requests';
 
-import {isInsideComponentDecorator, isInsideInlineTemplateRegion} from './embedded_support';
 import {ProgressReporter} from './progress-reporter';
 
 interface GetTcbResponse {
@@ -51,37 +50,6 @@ export class AngularLanguageClient implements vscode.Disposable {
       // Don't let our output console pop open
       revealOutputChannelOn: lsp.RevealOutputChannelOn.Never,
       outputChannel: this.outputChannel,
-      middleware: {
-        provideDefinition: async (
-            document: vscode.TextDocument, position: vscode.Position,
-            token: vscode.CancellationToken, next: lsp.ProvideDefinitionSignature) => {
-          if (isInsideComponentDecorator(document, position)) {
-            return next(document, position, token);
-          }
-        },
-        provideTypeDefinition: async (
-            document: vscode.TextDocument, position: vscode.Position,
-            token: vscode.CancellationToken, next) => {
-          if (isInsideInlineTemplateRegion(document, position)) {
-            return next(document, position, token);
-          }
-        },
-        provideHover: async (
-            document: vscode.TextDocument, position: vscode.Position,
-            token: vscode.CancellationToken, next: lsp.ProvideHoverSignature) => {
-          if (isInsideInlineTemplateRegion(document, position)) {
-            return next(document, position, token);
-          }
-        },
-        provideCompletionItem: async (
-            document: vscode.TextDocument, position: vscode.Position,
-            context: vscode.CompletionContext, token: vscode.CancellationToken,
-            next: lsp.ProvideCompletionItemsSignature) => {
-          if (isInsideInlineTemplateRegion(document, position)) {
-            return next(document, position, context, token);
-          }
-        }
-      }
     };
   }
 
@@ -345,4 +313,4 @@ function getServerOptions(ctx: vscode.ExtensionContext, debug: boolean): lsp.Nod
       execArgv: debug ? devExecArgv : prodExecArgv,
     },
   };
-}
+}

client/src/embedded_support.ts

@@ -1,23 +1,12 @@
 {
   "extends": "../tsconfig.json",
   "compilerOptions": {
-    "composite": true,
     "outDir": "../dist/client",
-    "rootDir": "src",
-    "rootDirs": [
-      ".",
-      "../dist"
-    ]
+    "rootDirs": [".", "../dist"]
   },
   "references": [
-    {
-      "path": "../common"
-    }
+    {"path": "../common"}
   ],
-  "include": [
-    "src"
-  ],
-  "exclude": [
-    "node_modules"
-  ]
-}
+  "include": ["src"],
+  "exclude": ["node_modules"]
+}