fix: check config file errors length (#407)

Keen Yee Liau · ayazhafiz · commit 95b8f11472dc · 2019-10-09T14:38:13.000-05:00
`configFileErrors` returned by `openClientFile()` is an empty array even
if there's no error, so check for its length besides truthiness.
diff --git a/server/src/session.ts b/server/src/session.ts
@@ -145,7 +145,8 @@ export class Session {
     const result = this.projectService.openClientFile(filePath, text, scriptKind);
 
     const {configFileName, configFileErrors} = result;
-    if (configFileErrors) {
+    if (configFileErrors && configFileErrors.length) {
+      // configFileErrors is an empty array even if there's no error, so check length.
       this.connection.console.error(configFileErrors.map(e => e.messageText).join('\n'));
     }
     if (!configFileName) {

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,8 @@ export class Session {`
`145`	`145`	`const result = this.projectService.openClientFile(filePath, text, scriptKind);`
`146`	`146`
`147`	`147`	`const {configFileName, configFileErrors} = result;`
`148`		`- if (configFileErrors) {`
	`148`	`+ if (configFileErrors && configFileErrors.length) {`
	`149`	`+ // configFileErrors is an empty array even if there's no error, so check length.`
`149`	`150`	`this.connection.console.error(configFileErrors.map(e => e.messageText).join('\n'));`
`150`	`151`	`}`
`151`	`152`	`if (!configFileName) {`