feat(server): Definitions for sources compiled with declarationMap … (#1601)

* feat(server): Definitions for sources compiled with `declarationMap` go to original source

The TypeScript language service has the ability to map definitions back
to their original source when the library code was compiled with
`declarationMap`. However, this functionality is not exposed as public
API. As a result, these methods could change in the future without our knowledge.

resolves #1588

* fixup! feat(server): Definitions for sources compiled with `declarationMap` go to original source

Author: atscott

integration/lsp/ivy_spec.ts

@@ -160,6 +160,28 @@ describe('Angular Ivy language server', () => {
     });
   });
 
+  it('goes to definition of original source when compiled with source maps', async () => {
+    client.sendNotification(lsp.DidOpenTextDocumentNotification.type, {
+      textDocument: {
+        uri: FOO_TEMPLATE_URI,
+        languageId: 'html',
+        version: 1,
+        text: `<lib-post></lib-post>`,
+      },
+    });
+    const languageServiceEnabled = await waitForNgcc(client);
+    expect(languageServiceEnabled).toBeTrue();
+    const response = await client.sendRequest(lsp.DefinitionRequest.type, {
+      textDocument: {
+        uri: FOO_TEMPLATE_URI,
+      },
+      position: {line: 0, character: 1},
+    }) as lsp.LocationLink[];
+    expect(Array.isArray(response)).toBe(true);
+    const {targetUri} = response[0];
+    expect(targetUri).toContain('libs/post/src/lib/post.component.ts');
+  });
+
   describe('signature help', () => {
     it('should show signature help for an empty call', async () => {
       client.sendNotification(lsp.DidOpenTextDocumentNotification.type, {

integration/project/app/app.module.ts

@@ -1,16 +1,20 @@
-import { CommonModule } from '@angular/common';
-import { NgModule }      from '@angular/core';
-import { AppComponent }  from './app.component';
-import { FooComponent } from './foo.component';
+import {CommonModule} from '@angular/common';
+import {NgModule} from '@angular/core';
+import {PostModule} from 'post';
+
+import {AppComponent} from './app.component';
+import {FooComponent} from './foo.component';
 
 @NgModule({
-  imports:      [
+  imports: [
     CommonModule,
+    PostModule,
   ],
   declarations: [
     AppComponent,
     FooComponent,
   ],
-  bootstrap:    [ AppComponent ]
+  bootstrap: [AppComponent]
 })
-export class AppModule { }
+export class AppModule {
+}

integration/project/app/foo.component.html

@@ -1,4 +1,5 @@
 {{title | uppercase}}
 <span class="subtitle">
     subtitle
-</span>
+</span>
+<lib-post></lib-post>

integration/project/libs/post/ng-package.json

@@ -0,0 +1,7 @@
+{
+	"$schema": "../../node_modules/ng-packagr/ng-package.schema.json",
+	"dest": "../../dist/post",
+	"lib": {
+		"entryFile": "src/index.ts"
+	}
+}

integration/project/libs/post/package.json

@@ -0,0 +1,10 @@
+{
+	"name": "post",
+	"version": "0.0.1",
+	"peerDependencies": {
+		"@angular/core": "^13.0.0"
+	},
+	"dependencies": {
+		"tslib": "^2.3.0"
+	}
+}

integration/project/libs/post/src/index.ts

@@ -0,0 +1 @@
+export * from './lib/post.component';

integration/project/libs/post/src/lib/post.component.ts

@@ -0,0 +1,16 @@
+import {Component, NgModule} from '@angular/core';
+
+@Component({
+  selector: 'lib-post',
+  template: '{{random}}',
+})
+export class PostComponent {
+  random = Math.random();
+}
+
+@NgModule({
+  declarations: [PostComponent],
+  exports: [PostComponent],
+})
+export class PostModule {
+}

integration/project/libs/post/tsconfig.json

@@ -0,0 +1,16 @@
+{
+	"extends": "../../tsconfig.json",
+	"files": [],
+	"include": [
+		"**/*.ts"
+	],
+	"compilerOptions": {
+		"outDir": "../../tsc-dist/post",
+		"rootDir": ".",
+		"declaration": true,
+		"declarationMap": true,
+		"inlineSources": true,
+		"sourceMap": true,
+		"types": []
+	},
+}

integration/project/package.json

@@ -8,5 +8,12 @@
     "@angular/core": "13.0.0-rc.3",
     "rxjs": "6.6.7",
     "zone.js": "0.11.4"
+  },
+  "devDependencies": {
+    "ng-packagr": "^13.2.0",
+    "typescript": "~4.4.3"
+  },
+  "scripts": {
+    "build": "ng-packagr -p libs/post/ng-package.json -c libs/post/tsconfig.json"
   }
-}
+}

integration/project/tsconfig.json

@@ -6,10 +6,16 @@
     "strict": true,
     "typeRoots": [
       "node_modules/@types"
-    ]
+    ],
+    "baseUrl": ".",
+    "paths": {
+      "post": [
+        "dist/post"
+      ]
+    }
   },
   "angularCompilerOptions": {
     "strictTemplates": true,
     "strictInjectionParameters": true
   }
-}
+}