Skip to content

Commit a3b973e

Browse files
ayazhafizKeen Yee Liau
authored andcommitted
fix: enable debug mode only when it is strictly turned on
Enable debug mode in the language server if `NG_DEBUG` is strictly "true". This fixes issues where `NG_DEBUG=false` would enable debug mode. Closes #579
1 parent 53a46b6 commit a3b973e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

client/src/extension.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export function activate(context: vscode.ExtensionContext) {
4444
};
4545

4646
// Create the language client and start the client.
47-
const forceDebug = !!process.env['NG_DEBUG'];
47+
const forceDebug = process.env['NG_DEBUG'] === 'true';
4848
const client =
4949
new lsp.LanguageClient('Angular Language Service', serverOptions, clientOptions, forceDebug);
5050

server/src/server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ session.info(`Angular language server process ID: ${process.pid}`);
4444
session.info(`Using typescript v${ts.version} from ${ts.resolvedPath}`);
4545
session.info(`Using @angular/language-service v${ng.version} from ${ng.resolvedPath}`);
4646
session.info(`Log file: ${logger.getLogFileName()}`);
47-
if (process.env.NG_DEBUG) {
47+
if (process.env.NG_DEBUG === 'true') {
4848
session.info('Angular Language Service is running under DEBUG mode');
4949
}
5050
if (process.env.TSC_NONPOLLING_WATCHER !== 'true') {

0 commit comments

Comments
 (0)