Skip to content

Commit cdb3751

Browse files
kyliauKeen Yee Liau
authored andcommitted
fix: enable type definition provider for Ivy only
View Engine language service does not support `getTypeDefinitionAtPosition`. See https://github.com/angular/angular/blob/3a6e7b5d2a54d011832191b96df5d8fd28a28740/packages/language-service/src/ts_plugin.ts#L113-L116
1 parent 16b2c42 commit cdb3751

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

integration/lsp/viewengine_spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ describe('initialization', () => {
122122
triggerCharacters: ['<', '.', '*', '[', '(', '$', '|'],
123123
},
124124
definitionProvider: true,
125-
typeDefinitionProvider: true,
125+
typeDefinitionProvider: false,
126126
hoverProvider: true,
127127
workspace: {
128128
workspaceFolders: {

server/src/session.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,7 @@ export class Session {
257257
triggerCharacters: ['<', '.', '*', '[', '(', '$', '|']
258258
},
259259
definitionProvider: true,
260-
typeDefinitionProvider: true,
260+
typeDefinitionProvider: this.ivy,
261261
hoverProvider: true,
262262
workspace: {
263263
workspaceFolders: {supported: true},

0 commit comments

Comments
 (0)