fix(ls): correct error position reported

additional: formatting

Author: chuckjaz

client/package.json

@@ -11,9 +11,10 @@
     "Languages"
   ],
 	"activationEvents": [
-		"onLanguage:ng-template"
+		"onLanguage:ng-template",
+    "onLanguage:html"
 	],
-	"main": "./out/extension",  
+	"main": "./out/extension",
   "contributes": {
     "languages": [
       {

client/src/extension.ts

@@ -6,36 +6,37 @@ import { workspace, Disposable, ExtensionContext } from 'vscode';
 import { LanguageClient, LanguageClientOptions, SettingMonitor, ServerOptions, TransportKind } from 'vscode-languageclient';
 
 export function activate(context: ExtensionContext) {
-	// The server is implemented in node
-	let serverModule = context.asAbsolutePath(path.join('server', 'server.js'));
-	// The debug options for the server
-	let debugOptions = { execArgv: ["--nolazy", "--debug=6004"] };
-	
-	// If the extension is launched in debug mode then the debug server options are used
-	// Otherwise the run options are used
-	let serverOptions: ServerOptions = {
-		run : { module: serverModule, transport: TransportKind.ipc },
-		debug: { module: serverModule, transport: TransportKind.ipc, options: debugOptions }
-	}
-	
-	// Options to control the language client
-	let clientOptions: LanguageClientOptions = {
-		// Register the server for plain text documents
-		documentSelector: ['ng-template'],
-		synchronize: {
-			fileEvents: [
-				workspace.createFileSystemWatcher('**/tsconfig.json'),
-				workspace.createFileSystemWatcher('**/*.ts')
-			],
-			textDocumentFilter: document => document.fileName.endsWith('.ts') 
-		},
-	}
-	
-	// Create the language client and start the client.
-	let disposable = new LanguageClient('Angular Language Service', serverOptions, clientOptions, true).start();
-	
-	// Push the disposable to the context's subscriptions so that the 
-	// client can be deactivated on extension deactivation
-	context.subscriptions.push(disposable);
+  // The server is implemented in node
+  let serverModule = context.asAbsolutePath(path.join('server', 'server.js'));
+  // The debug options for the server
+  let debugOptions = { execArgv: ["--nolazy", "--debug=6004"] };
+
+  // If the extension is launched in debug mode then the debug server options are used
+  // Otherwise the run options are used
+  let serverOptions: ServerOptions = {
+    run : { module: serverModule, transport: TransportKind.ipc },
+    debug: { module: serverModule, transport: TransportKind.ipc, options: debugOptions }
+  }
+
+  // Options to control the language client
+  let clientOptions: LanguageClientOptions = {
+    // Register the server for Angular templates
+    documentSelector: ['ng-template', 'html'],
+
+    // Information in the TypeScript project is necessary to generate Angular template completions
+    synchronize: {
+      fileEvents: [
+        workspace.createFileSystemWatcher('**/tsconfig.json'),
+        workspace.createFileSystemWatcher('**/*.ts')
+      ],
+      textDocumentFilter: document => document.fileName.endsWith('.ts')
+    },
+  }
+
+  // Create the language client and start the client.
+  let disposable = new LanguageClient('Angular Language Service', serverOptions, clientOptions, true).start();
+
+  // Push the disposable to the context's subscriptions so that the
+  // client can be deactivated on extension deactivation
+  context.subscriptions.push(disposable);
 }
- 

server/.vscode/settings.json

@@ -2,5 +2,6 @@
 {
   "typescript.tsdk": "./node_modules/typescript/lib",
   "editor.useTabStops": false,
+  "editor.insertSpaces": true,
   "editor.tabSize": 2
 }

server/src/documents.ts

@@ -193,7 +193,7 @@ export class TextDocuments {
 
   public offsetsToPositions(document: TextDocumentIdentifier, offsets: number[]): Position[] {
     const file = uriToFileName(document.uri);
-    return this.projectService.positionsToLineOffsets(file, offsets).map(lineOffset => Position.create(lineOffset.line, lineOffset.col));
+    return this.projectService.positionsToLineOffsets(file, offsets).map(lineOffset => Position.create(lineOffset.line - 1, lineOffset.col - 1));
   }
 
   public getNgService(document: TextDocumentIdentifier): LanguageService | undefined {