fix(syntaxes): Single quote should end as alias match (#1956)

While uncommon, single quotes can be used for HTML attribute values.

fixes #1912

Author: atscott

syntaxes/expression.json

@@ -138,7 +138,7 @@
               "name": "storage.type.as.ts"
             }
           },
-          "end": "(?=$|\"|[;,:})\\]])",
+          "end": "(?=$|\"|'|[;,:})\\]])",
           "patterns": [
             {
               "include": "#type"

syntaxes/src/expression.ts

@@ -147,7 +147,7 @@ export const Expression: GrammarDefinition = {
               name: 'storage.type.as.ts',
             },
           },
-          end: /(?=$|"|[;,:})\]])/,
+          end: /(?=$|"|'|[;,:})\]])/,
           patterns: [
             {
               include: '#type',

syntaxes/test/data/expression.html

@@ -91,6 +91,7 @@
 <!-- As Expression -->
 <div *ngFor="let param of params; index as i;"></div>
 <div *ngFor="let param of params; index as i"></div>
+<div *ngIf='x as y'></div>
 <!-- Mixed -->
 <div *ngFor="let param of params; let i = index; let last = last"></div>
 <div *ngFor="let param of params; let i = index; let last = last;"></div>
@@ -115,4 +116,4 @@
 <div *ngFor="let n of nums; index as i"></div>
 <div *matHeaderCellDef></div>
 <!-- #613 -->
-<div *ngIf="x$ | async as a"></div>
+<div *ngIf="x$ | async as a"></div>

syntaxes/test/data/expression.html.snap

@@ -1025,6 +1025,19 @@
 #                                           ^ template.ng meta.ng-binding.template.html expression.ng entity.name.type.ts
 #                                            ^ template.ng meta.ng-binding.template.html string.quoted.html punctuation.definition.string.end.html
 #                                             ^^^^^^^^ template.ng
+><div *ngIf='x as y'></div>
+#^^^^^ template.ng
+#     ^ template.ng meta.ng-binding.template.html entity.other.attribute-name.html entity.other.ng-binding-name.template.html punctuation.definition.ng-binding-name.begin.html
+#      ^^^^ template.ng meta.ng-binding.template.html entity.other.attribute-name.html entity.other.ng-binding-name.template.html entity.other.ng-binding-name.ngIf.html
+#          ^ template.ng meta.ng-binding.template.html punctuation.separator.key-value.html
+#           ^ template.ng meta.ng-binding.template.html string.quoted.html punctuation.definition.string.begin.html
+#            ^ template.ng meta.ng-binding.template.html expression.ng variable.other.readwrite.ts
+#             ^ template.ng meta.ng-binding.template.html expression.ng
+#              ^^ template.ng meta.ng-binding.template.html expression.ng storage.type.as.ts
+#                ^ template.ng meta.ng-binding.template.html expression.ng
+#                 ^ template.ng meta.ng-binding.template.html expression.ng entity.name.type.ts
+#                  ^ template.ng meta.ng-binding.template.html string.quoted.html punctuation.definition.string.end.html
+#                   ^^^^^^^^ template.ng
 ><!-- Mixed -->
 #^^^^^^^^^^^^^^^ template.ng
 ><div *ngFor="let param of params; let i = index; let last = last"></div>
@@ -1453,4 +1466,5 @@
 #                         ^ template.ng meta.ng-binding.template.html expression.ng
 #                          ^ template.ng meta.ng-binding.template.html expression.ng entity.name.type.ts
 #                           ^ template.ng meta.ng-binding.template.html string.quoted.html punctuation.definition.string.end.html
-#                            ^^^^^^^^ template.ng
+#                            ^^^^^^^^ template.ng
+>