Skip to content
This repository was archived by the owner on Sep 16, 2022. It is now read-only.

Commit 4afb749

Browse files
leonsenftmatanlurey
authored andcommitted
chore(Router): remove workaround for #1389 from test
PiperOrigin-RevId: 200573482
1 parent 6ded0a0 commit 4afb749

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

angular_router/test/regression/1374_redirect_test.dart

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,7 @@ Future<List<String>> redirect([NavigationParams params]) async {
4848
.forComponent<TestRedirectComponent>(ng.TestRedirectComponentNgFactory)
4949
.addInjector(injector);
5050
final testFixture = await testBed.create();
51-
final urlChanges = testFixture.assertOnlyInstance.locationStrategy.urlChanges
52-
// TODO(leonsenft): due to https://github.com/dart-lang/angular/issues/1389,
53-
// the initial navigation to '/' succeeds despite there being no matching
54-
// route. URL changes due to this navigation are cleared as they're of no
55-
// interest to the tests calling this function. To be removed when the issue
56-
// is fixed.
57-
..clear();
51+
final urlChanges = testFixture.assertOnlyInstance.locationStrategy.urlChanges;
5852
final router = testFixture.assertOnlyInstance.router;
5953
final result = await router.navigate('/from', params);
6054
expect(result, NavigationResult.SUCCESS);

0 commit comments

Comments
 (0)