Skip to content
This repository was archived by the owner on May 20, 2023. It is now read-only.

Commit 17dad7e

Browse files
TedSandernshahan
authored andcommitted
rollback of changelist 241965449.
*** Reason for rollback *** Found a different way to preform the animation without needing this functionality. Rolling back to reduce the maintenance burden of the feature until we find a reason without a better work around. *** Original change description *** Adding isActive flag to focus trap. Focus Trap needs a property to determine if it is active or not when dealing with elements that aren't or can't be hidden. *** PiperOrigin-RevId: 242981425
1 parent 30de929 commit 17dad7e

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

angular_components/lib/focus/focus_trap.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,6 @@ class FocusTrapComponent implements OnDestroy {
3737
}
3838
}
3939

40-
/// Whether or not the focus trap is active
41-
@Input()
42-
bool isActive = true;
43-
4440
@override
4541
void ngOnDestroy() {
4642
_disposer.dispose();

angular_components/lib/focus/focus_trap.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
for details. All rights reserved. Use of this source code is governed by a
44
BSD-style license that can be found in the LICENSE file.
55
-->
6-
<div (focus)="focusLast()" [attr.tabindex]="isActive ? 0 : null"></div>
7-
<div focusContentWrapper [attr.tabindex]="isActive ? -1 : null" style="outline: none">
6+
<div (focus)="focusLast()" tabindex="0"></div>
7+
<div focusContentWrapper tabindex="-1" style="outline: none">
88
<ng-content></ng-content>
99
</div>
10-
<div (focus)="focusFirst()" [attr.tabindex]="isActive ? 0 : null"></div>
10+
<div (focus)="focusFirst()" tabindex="0"></div>

0 commit comments

Comments
 (0)