Merge pull request #304 from dart-lang/github-sync

GitHub sync

Author: TedSander

CHANGELOG.md

@@ -1,3 +1,35 @@
+## 0.9.0-beta+2
+
+> NOTE: This code is considered production quality, but depends on angular:
+> 5.0.0-beta+2 (5.0.0-beta+2 is used in production Google apps).
+
+### Breaking Changes
+* Remove `SelectableChangeNotifier` and deprecate `SelectableWithComposition`
+  with the intention to remove. They are widely unused, complicated the
+  implementations, and unsound in Dart 2.
+
+#### Material Dialog
+* Fix bug where a disposable could be added to its disposer after it had already
+  been destroyed.
+
+#### Material Icon
+* Add aria label and use them for trailing/leading icons of Material Input.
+
+#### Material Popup
+* Change `<main>` html tag to a `<div>`. HTML5 states there should only be one
+  main tag per application.
+
+### Other Updates
+#### Miscellaneous
+* Add `is{Selectable|Disabled|Hidden}In()`, `getOptionIn()` and, `filterWhere()`
+  as static helpers to `Selectable`.
+* Add a lookup method for finding the closest Material Color name based on any
+  input color.
+
+#### Dart 2 Updates
+* Fixes for Dart 2 compile-time and runtime errors.
+* Applicaion of `dartfmt --fix`.
+
 ## 0.9.0-beta+1
 
 > NOTE: This code is considered production quality, but depends on angular:

lib/angular_components.dart

@@ -220,7 +220,7 @@ export 'utils/async/async.dart';
 
 /// A convenience list of all Directives exposed by this package.
 @Deprecated('List the directives used by your app for smaller code size.')
-const List<dynamic> materialDirectives = const [
+const List<dynamic> materialDirectives = [
   AutoDismissDirective,
   AutoFocusDirective,
   ButtonDirective,
@@ -324,6 +324,6 @@ const List<dynamic> materialDirectives = const [
 ];
 
 /// A convenience list of all providers exposed by this package.
-const List<dynamic> materialProviders = const [
+const List<dynamic> materialProviders = [
   datepickerBindings,
 ];

lib/annotations/rtl_annotation.dart

@@ -12,10 +12,10 @@ import 'package:angular/angular.dart';
 /// This is used to only read the DOM once for an app to determine if the app
 /// itself is RTL. Only use this for components whose RTL is not independant
 /// of the application as a whole.
-const rtlToken = const OpaqueToken('isRtl');
+const rtlToken = OpaqueToken('isRtl');
 
 const rtlProvider =
-    const Provider(rtlToken, useFactory: determineRtl, deps: const [Document]);
+    Provider(rtlToken, useFactory: determineRtl, deps: [Document]);
 
 @Injectable()
 bool determineRtl(Document document) =>

lib/app_layout/material_drawer_base.dart

@@ -9,7 +9,7 @@ import 'package:angular_components/content/deferred_content_aware.dart';
 
 // When deferred content should be removed. Needs to be longer than the longest
 // animation.
-const animationDuration = const Duration(milliseconds: 500);
+const animationDuration = Duration(milliseconds: 500);
 
 class MaterialDrawerBase implements DeferredContentAware, OnInit {
   MaterialDrawerBase({bool visible = true}) : _visible = visible;
@@ -26,7 +26,7 @@ class MaterialDrawerBase implements DeferredContentAware, OnInit {
 
     if (!_visible) {
       // Wait until after the animation to remove the content
-      new Timer(animationDuration, () {
+      Timer(animationDuration, () {
         // Make sure we are still not visible in case the drawer was toggled
         // quickly before the animation was done.
         if (!_visible) _visibleChange.add(_visible);
@@ -37,7 +37,7 @@ class MaterialDrawerBase implements DeferredContentAware, OnInit {
     }
   }
 
-  final _visibleChange = new StreamController<bool>.broadcast(sync: true);
+  final _visibleChange = StreamController<bool>.broadcast(sync: true);
 
   /// Event fired when the visibility of the drawer changes.
   ///

lib/app_layout/material_persistent_drawer.dart

@@ -16,8 +16,8 @@ import 'material_drawer_base.dart';
 @Directive(
   selector: 'material-drawer[persistent]',
   exportAs: 'drawer',
-  providers: const [
-    const Provider(DeferredContentAware,
+  providers: [
+    Provider(DeferredContentAware,
         useExisting: MaterialPersistentDrawerDirective),
   ],
   visibility: Visibility.all, // Injected by child elements.

lib/app_layout/material_stackable_drawer.dart

@@ -14,12 +14,12 @@ import 'package:angular_components/content/deferred_content_aware.dart';
 /// Works with deferred content.
 @Component(
   selector: 'material-drawer[stackable]',
-  providers: const [
-    const Provider(DeferredContentAware,
+  providers: [
+    Provider(DeferredContentAware,
         useExisting: MaterialStackableDrawerComponent),
   ],
   templateUrl: 'material_stackable_drawer.html',
-  styleUrls: const ['material_stackable_drawer.scss.css'],
+  styleUrls: ['material_stackable_drawer.scss.css'],
   visibility: Visibility.all, // Injected by child elements.
 )
 class MaterialStackableDrawerComponent

lib/app_layout/material_temporary_drawer.dart

@@ -13,12 +13,12 @@ import 'material_drawer_base.dart';
 @Component(
   selector: 'material-drawer[temporary]',
   exportAs: 'drawer',
-  providers: const [
-    const Provider(DeferredContentAware,
+  providers: [
+    Provider(DeferredContentAware,
         useExisting: MaterialTemporaryDrawerComponent),
   ],
   templateUrl: 'material_temporary_drawer.html',
-  styleUrls: const ['material_temporary_drawer.scss.css'],
+  styleUrls: ['material_temporary_drawer.scss.css'],
   changeDetection: ChangeDetectionStrategy.OnPush,
   visibility: Visibility.all, // Injected by child elements.
 )

lib/builder.dart

@@ -6,4 +6,4 @@ import 'package:build/build.dart';
 import 'package:sass_builder/sass_builder.dart';
 
 Builder scssBuilder(BuilderOptions options) =>
-    new SassBuilder(outputExtension: '.scss.css');
+    SassBuilder(outputExtension: '.scss.css');

lib/button_decorator/button_decorator.dart

@@ -31,7 +31,7 @@ class ButtonDirective extends RootFocusable
   @Output()
   Stream<UIEvent> get trigger => _trigger.stream;
 
-  final _trigger = new StreamController<UIEvent>.broadcast(sync: true);
+  final _trigger = StreamController<UIEvent>.broadcast(sync: true);
 
   String _hostTabIndex;
   String _role;

lib/content/deferred_content.dart

@@ -20,8 +20,8 @@ import 'deferred_content_aware.dart';
   selector: '[deferredContent]',
 )
 class DeferredContentDirective implements OnDestroy {
-  final _disposer = new Disposer.oneShot();
-  final _placeholder = new DivElement();
+  final _disposer = Disposer.oneShot();
+  final _placeholder = DivElement();
 
   ViewContainerRef _viewContainer;
   EmbeddedViewRef _viewRef;
@@ -101,7 +101,7 @@ class DeferredContentDirective implements OnDestroy {
 class CachingDeferredContentDirective implements OnDestroy {
   ViewContainerRef _viewContainer;
   TemplateRef _template;
-  final _disposer = new Disposer.oneShot();
+  final _disposer = Disposer.oneShot();
   ViewRef _view;
 
   // Keep around the current state.