Skip to content
This repository was archived by the owner on May 20, 2023. It is now read-only.

Commit 3ff5db0

Browse files
rkjnshahan
authored andcommitted
Remove visibility.all from @component annotations. This is potentially BREAKING
change. Please review carefully. Breakage will only be caught if the code is covered by tests. Reject this change if you believe it breaks you. If the component needs to be injected anywhere in the app, you can get a runtime exception after this change. This should be caught by tests using your components, and fixing the issue should be trivial, as the exceptions have good error messages, such as "No provider found for FooComponent". PiperOrigin-RevId: 190967251
1 parent 21e4b25 commit 3ff5db0

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

lib/focus/focus.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -199,9 +199,8 @@ class AutoFocusDirective extends RootFocusable implements OnInit, OnDestroy {
199199

200200
/// This directive is used to [ViewChild] focusable element in your view.
201201
@Directive(
202-
selector: '[focusableElement]', exportAs: 'focusableElement',
203-
// TODO(google): Change to `Visibility.local` to reduce code size.
204-
visibility: Visibility.all,
202+
selector: '[focusableElement]',
203+
exportAs: 'focusableElement',
205204
)
206205
class FocusableDirective extends RootFocusable {
207206
FocusableDirective(HtmlElement node) : super(node);

0 commit comments

Comments
 (0)