Skip to content
This repository was archived by the owner on May 20, 2023. It is now read-only.

Commit 40b512d

Browse files
keertipnshahan
authored andcommitted
Fix previously uncaught violations of invalid override method parameter default values.
More correct checking of invalid override method parameter default values recently landed in the SDK [1]. The changes fit a few shapes, given a method `m1`, which overrides a method `m2`: * If `m2` has a parameter `p` with a default value, but the parameter `p` on `m1` does _not_ have a default value, I have added a default value. * If `m2` has a parameter `p` with a default value, and the parameter `p` on `m1` has a _different_ default value, I have either: * changed the default value on `m1` to equal that on `m2`, or * removed the default value on `m2`, instead assigning it with `??=` as the first statement in the method body. [1] dart-lang/sdk#34437 PiperOrigin-RevId: 233486440
1 parent 823f90a commit 40b512d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

angular_components/lib/model/selection/select.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ abstract class Filterable {
4242
/// filter('re', limit: 5) for return colors whose names start with 're'
4343
/// filter(new DateTime.now(), limit: 10) for showing only meeting that are in
4444
/// the future.
45-
DisposableFuture<bool> filter(Object filterQuery, {int limit = -1});
45+
DisposableFuture<bool> filter(Object filterQuery, {int limit});
4646
}
4747

4848
/// Interface implemented by classes that support children.

0 commit comments

Comments
 (0)