Skip to content
This repository was archived by the owner on May 20, 2023. It is now read-only.

Commit 4c39073

Browse files
Googlernshahan
authored andcommitted
Automated g4 rollback of changelist 259425716.
*** Reason for rollback *** Broke client tests *** Original change description *** Add menu item affix for rendering deprecation warning in material menu. Add deprecation icon to deprecated filter items. *** PiperOrigin-RevId: 259451190
1 parent fb3eaed commit 4c39073

File tree

4 files changed

+1
-17
lines changed

4 files changed

+1
-17
lines changed

angular_components/lib/material_menu/menu_item_groups.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@
8888
</span>
8989
</span>
9090
<menu-item-affix-list
91-
*ngIf="item.hasVisibleSuffixes"
91+
*ngIf="item.itemSuffixes.isNotEmpty"
9292
class="suffix-list"
9393
[disabled]="!item.enabled"
9494
[items]="item.itemSuffixes">

angular_components/lib/model/menu/delegating_menu_item.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,4 @@ class DelegatingMenuItem<SubMenuType> implements MenuItem<SubMenuType> {
7777

7878
@override
7979
String get secondaryLabel => _delegate.secondaryLabel;
80-
81-
@override
82-
bool get hasVisibleSuffixes => _delegate.hasVisibleSuffixes;
8380
}

angular_components/lib/model/menu/menu.dart

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -203,12 +203,6 @@ class MenuItem<T> with MenuItemMixin implements HasUIDisplayName, HasIcon {
203203
'Only one of itemSuffix or itemSuffixes should be provided');
204204
}
205205

206-
/// True if any of the [itemSuffixes] are rendered.
207-
///
208-
/// Rendered suffixes include those that are visible on hover. Hidden suffixes
209-
/// are excluded.
210-
bool get hasVisibleSuffixes => itemSuffixes.any((suffix) => suffix.isVisible);
211-
212206
@override
213207
String toString() => {
214208
'label': label,

angular_components/lib/model/menu/selectable_menu.dart

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -204,13 +204,6 @@ class SelectableMenuItem<ItemType> extends PropertyChangeNotifier
204204
_selectableState = value;
205205
notifyPropertyChange(#selectableState, _selectableState, value);
206206
}
207-
208-
/// True if any of the [itemSuffixes] are rendered.
209-
///
210-
/// Rendered suffixes include those that are visible on hover. Hidden suffixes
211-
/// are excluded.
212-
@override
213-
bool get hasVisibleSuffixes => itemSuffixes.any((suffix) => suffix.isVisible);
214207
}
215208

216209
void _noOp() {}

0 commit comments

Comments
 (0)