Skip to content
This repository was archived by the owner on May 20, 2023. It is now read-only.

Commit 5d4d560

Browse files
TedSandernshahan
authored andcommitted
Migrate away from QueryList in scoreboard.
PiperOrigin-RevId: 186535357
1 parent 57dc62c commit 5d4d560

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

lib/scorecard/scoreboard.dart

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,13 +70,14 @@ class ScoreboardComponent implements OnInit, OnDestroy {
7070
final ChangeDetectorRef _changeDetector;
7171
final DomService _domService;
7272
SelectionModel _selectionModel;
73-
QueryList<ScorecardComponent> _scorecards;
73+
List<ScorecardComponent> _scorecards;
7474
ScorecardBarDirective _scorecardBar;
7575
String chevronBack = chevronLeft;
7676
String chevronForward = chevronRight;
7777

7878
/// Whether to allow for uniform widths on scorecards.
7979
bool _enableUniformWidths;
80+
bool _initialized = false;
8081

8182
bool get isScrollable => scrollable && (_scorecardBar?.isScrollable ?? false);
8283
bool _atScorecardBarStart = false;
@@ -94,11 +95,11 @@ class ScoreboardComponent implements OnInit, OnDestroy {
9495
}
9596

9697
@ContentChildren(ScorecardComponent)
97-
set scoreCards(QueryList<ScorecardComponent> value) {
98+
set scoreCards(List<ScorecardComponent> value) {
9899
_scorecards = value;
99-
_disposer.addStreamSubscription(
100-
_scorecards.changes.listen((_) => _onScorecardsChange));
101-
scheduleMicrotask(_onScorecardsChange);
100+
// TODO(google): Remove if setting of content children occur after
101+
// child is initialized.
102+
if (_initialized) scheduleMicrotask(_onScorecardsChange);
102103
}
103104

104105
@override
@@ -116,6 +117,10 @@ class ScoreboardComponent implements OnInit, OnDestroy {
116117
_selectionModel = new SelectionModel();
117118
break;
118119
}
120+
if (!_initialized) {
121+
_initialized = true;
122+
scheduleMicrotask(_onScorecardsChange);
123+
}
119124
}
120125

121126
@override

0 commit comments

Comments
 (0)